Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2502425rdg; Mon, 14 Aug 2023 04:55:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgF+uCrMQIDrU1B6p+pI3EdWtdL0zZXuTxRVBsJ7F7oXir2VH3Ya1zWNekh2f6QYEqge4O X-Received: by 2002:a05:6402:541:b0:525:6e04:bcb3 with SMTP id i1-20020a056402054100b005256e04bcb3mr505221edx.40.1692014122895; Mon, 14 Aug 2023 04:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692014122; cv=none; d=google.com; s=arc-20160816; b=sWcz2SETnpTZveMpgX3vweFQAHbH3dgTAr3lgk8gIbc/aoXolNHhR6bOY0yBjXSNG/ PRBWgirfsXzsFNPtwrkxMM2mYlFJ25WBzUtFCuN+/1EN8mh+e9HLMDwA1ph3AzCyop+Z sTRFHBZAU+tquAeOYPUGyr13pkDL1+Q+19enu27ajtOJ6JaCr7Rb+bhB6Yy+iJJKE11i x+lqqvjUg0Avtdci1zfAN6p+pDHc90m1nrZ/SE5SoIi5Vw5zSc7RIeqoNX7natSxiGE9 PEEG8zLg9X5XNkmvOZrPR7wPuFlnx9c8S4e9buuV2/BUG+FRvLuKolfcOdhxxx2Wg77b mRxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=gpFUakM9U9BclH5hKRnHKIPFG3rdR19+7vcbSkpu9+8=; fh=7iC+K1Bo2+OaZhPZNOkG6w74KpnV63TEMVt+3d9HrjY=; b=F1iEeVnQogQoaED1Ux1XFPXd48GgDK8lDM7eW7ucpcD4HnDBnySspKPwR2sTHOZvcv NrD4ZVFJAtUDT0l5Cwkrqn0pIsHYLfr1aA3dHFYBLeRSOZitESMIg+Zq7KUrOAvsqZ0W BuMnXmWoXPPdySMKbbwFNr/qjKHG0LQuio9FweVlI++cWOf7il3onHtwxdMnTpZUoIef 9GFD0Eb+ew4zuvM6Vpk2YilHPNoN0KWG7F1/CPuE4YNbveJUxiRdXsmedZeg/hvOkDd7 vtDOZdkDj3A5gEf2xsOI99X4a6aEpa+aoAmAiYBQ6rZXUEUoPkiTJB2CcauSmGAwxkNy 3wjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="HV0WDI/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r18-20020a056402035200b005233f616fdcsi7527168edw.465.2023.08.14.04.54.58; Mon, 14 Aug 2023 04:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="HV0WDI/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235525AbjHNKHQ (ORCPT + 99 others); Mon, 14 Aug 2023 06:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235268AbjHNKHB (ORCPT ); Mon, 14 Aug 2023 06:07:01 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57071E71 for ; Mon, 14 Aug 2023 03:06:58 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99357737980so550927866b.2 for ; Mon, 14 Aug 2023 03:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692007617; x=1692612417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gpFUakM9U9BclH5hKRnHKIPFG3rdR19+7vcbSkpu9+8=; b=HV0WDI/Epsk6hzNmAN9LNW2gBufN9Pdobqmt7ZKcvbXnEKAcR0AL9UdocNNR3wKylZ rQ0AWg4bDCWnl4ymonjqhTFAq+wwMt4RPBc3FP/Bils91iLDEWwP/cP16xbAkYb2q5AG DIpDAE/3wDpOpUqvANyoI0vj/8HY7TQAB0Koaf5m2+dCjPOoCEyt7xHgRqnemKll+Zt9 74uqNxZ8PwtVRIPq91fFSNRIp85i9AVNdE6DhklJKbSySJMs7I77OE4E2NAM54EZMqlJ 8/CGyvj6ikJoBWaZfyXB09PP7B4vYHECS9x497L4LP/qb84JdLnu0WdaRMZb+Sayz8UY ymgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692007617; x=1692612417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gpFUakM9U9BclH5hKRnHKIPFG3rdR19+7vcbSkpu9+8=; b=hahvkiN2zsL8Bl3b3/MQ/xfCGK6rsznVw/dlxesKev6epTsNp4es9YR1jRJM2nI96X lylkH8xCpfWhq6hQYnKjvK0EZdG4Qi6FExGzlJtgwRbfiboFMNPpD8at+MQTwM/+139D 7XDKBYlG9G2zrtymyAhhEVh1OEkq29+trSXvh1pMmQQ+BaCQMIZe3KLJpfE4Ccj7O2+d 1XZL3vjmRuBZQ9AMtYhkVWpNuY3ValrHgQvrS5doPD5LeDJUE2PrsvD6xOD71Mi4Zabb uUlqr1xoAoreqKFl+fjQ8Wis8QzuoRP+CRQZ5yswsIt7nSx5LNyKDP79YAubSkJU8UQ/ PnPQ== X-Gm-Message-State: AOJu0YypKahr1xZGXyWCymglT/IzxsLZksfC6ZiYyqMmb189RMmnDufH 5c6k1ux6kD8IVzZn2c72WXn3vQ== X-Received: by 2002:a17:906:3284:b0:99c:570a:e23e with SMTP id 4-20020a170906328400b0099c570ae23emr7695264ejw.24.1692007616819; Mon, 14 Aug 2023 03:06:56 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id b16-20020a170906039000b00993470682e5sm5499705eja.32.2023.08.14.03.06.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 03:06:56 -0700 (PDT) Message-ID: Date: Mon, 14 Aug 2023 12:06:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 2/3] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, agross@kernel.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, Konrad Dybcio , Dmitry Torokhov , linux-input@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_kamalw@quicinc.com, jestar@qti.qualcomm.com References: <20230731053712.2220898-1-quic_fenglinw@quicinc.com> <20230731053712.2220898-3-quic_fenglinw@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230731053712.2220898-3-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/2023 07:37, Fenglin Wu wrote: > Add compatible string 'qcom,spmi-vib-gen2' to support vibrator module > inside PMI632, PMI7250B, PM7325B, PM7550BA. > > Signed-off-by: Fenglin Wu > --- > .../bindings/input/qcom,pm8xxx-vib.yaml | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > index c8832cd0d7da..4a2319fc1e3f 100644 > --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > @@ -11,10 +11,18 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,pm8058-vib > - - qcom,pm8916-vib > - - qcom,pm8921-vib > + oneOf: > + - enum: > + - qcom,pm8058-vib > + - qcom,pm8916-vib > + - qcom,pm8921-vib > + - items: > + - enum: > + - qcom,pmi632-vib > + - qcom,pm7250b-vib > + - qcom,pm7325b-vib > + - qcom,pm7550b-vib > + - const: qcom,spmi-vib-gen2 This does not seem to implement my comment: "Entirely remove qcom,spmi-vib-gen2 and qcom,spmi-vib-gen1. Use device specific compatibles names only. As fallback and as first compatible." It's nice to respond that you disagree with it. Therefore, I am not going to Ack it. Best regards, Krzysztof