Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter
 atomic update feature
Thread-Topic: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter
 atomic update feature
Thread-Index: AQHZzqM2m5wCGyVjO0iGtLQ+gMszHQ==
Date:   Mon, 14 Aug 2023 11:33:57 +0000
Message-ID: <BY3PR18MB47072A3EBDA1664DE4C5AF6EA017A@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230807140535.3070350-1-saikrishnag@marvell.com>
        <20230809155022.132a69a7@kernel.org>
        <BY3PR18MB470745294C1B03C0DA5364E6A010A@BY3PR18MB4707.namprd18.prod.outlook.com>
 <20230811150449.64ce3512@kernel.org>
In-Reply-To: <20230811150449.64ce3512@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fIVylsmgsgyXSgz3TGbhuqmrhsG/8KDRJGp5i7TRSNttpe+3YpEDHEAKAa+v?=
 =?us-ascii?Q?3u68D8ZV7Ol3zZ2VqYzSAV3cxfL+pvdi5CkQEPRTMK0I+n5EBD60F1fkp9gk?=
 =?us-ascii?Q?zdpNWgNJAsFY+DgSo1X/n3p3YYoGLaVEmtKjK/Pz0fKYC2pWrU6uxA1ZwiHN?=
 =?us-ascii?Q?LZliZaZI2OQefU7tXm/yF3jyw0aXKSVsGQF895y7Tuit77wIpmYKGQDczeOn?=
 =?us-ascii?Q?a+3h/r1RcYjpPItfOhjB9PKelbOW2SERgXWzIgUZ6Ni1TrnDqd96B7EH9e90?=
 =?us-ascii?Q?xwNYCv2aAeSM8dwYF2SFPNdSm3kPJC+Ce++fz1mZQgBO1dTjPfqDzBmIsfI2?=
 =?us-ascii?Q?7eIHdBDgLhFhlfpF4aKEwWJMiYXMQDYcgWXQUPS5dEuecXSulFwNWp5N8iOY?=
 =?us-ascii?Q?XCddD8pRoIEbpeiB86q/skFoAbAm6x77L3YiEq6sVgFk2SpzYInPtL/PonVn?=
 =?us-ascii?Q?pphMVZxYY2K4PZuPzDqjOO5/B1G1+jSIjFK6N+o4TbZzDHMOgP1NZrI+GuCj?=
 =?us-ascii?Q?K8g5AdSqeP7GuSwW04W4soy8J/X65QKEvZJO/U/DzL6+1yMCElHilSGeuVLO?=
 =?us-ascii?Q?b+FVwCz9LBipVQNy2nEoTdv8akNk33QJdbBu+UkDhBBjRtVTvOanteVt39ev?=
 =?us-ascii?Q?L1Y5gJ/0DJrdC6dVJ68NUmUCaUnCOe84pKcEcIX3ERBRH69q+V2JtF/dyVwv?=
 =?us-ascii?Q?JrwMGiWrT0DBeEaZo7y4RGixkZWfbRAxilbZeA8GgRkRoPETypf2Dm5ArG63?=
 =?us-ascii?Q?9JZliJGVDikJURqO9SAP1qSgWI5jrVQ7gRuB8FJG6mIn+InsMzyRTwVSF1bg?=
 =?us-ascii?Q?AP1BsVIphb9y1+429YkeoE7pi/2EsaiQ38MrzUt6QMXPW0XX2nDUTy533J/X?=
 =?us-ascii?Q?ty1fA8wOUmNKI0XxWDX5HOYENEUO5yuQjXjW0swJJzvZvyUPG3Jk4j0PKOL0?=
 =?us-ascii?Q?9biLnCMWUK2waDQ5qE0nhoMuUhIBgIdTwMv+8Ka3GiZsGOps83TIQuJE8xcU?=
 =?us-ascii?Q?HoEFprDZtgqzqUMhD4ZvppuPykvRH7pJgLs8g6i0SLkidL6HQ6zGxnpvaKZp?=
 =?us-ascii?Q?KazTt/SZb0fvIOcWfh3HUzUJYpY0tSiAhgPi/K3nG3Zq7E1K4RpAZ4RA77a6?=
 =?us-ascii?Q?FpXK+JObcHItIJ00aj9Wr5dEkvK3oFDQ+GVJMBvCH97zQsRk6Atjs+L5+u4R?=
 =?us-ascii?Q?R8V5NMyaONx5p0geSP2ozmep1ug89dF+6ta/S5YnaI3kWhh+xFc/q7xV061B?=
 =?us-ascii?Q?O1lInzA9Q/H6/34YK2GLVVVc9ETSqb5XRmrlPKOa9jVdbOUtrTkwpuDAAbNs?=
 =?us-ascii?Q?gqEsvbJPmte0fZHcW6Fa7y3lPF3yiY77GKHlnPep74K4OYn4Lnxw7J7xRIT8?=
 =?us-ascii?Q?zPqsi+pB9oUnkqZtBG8PrlAegQQ/Uz7rPnl8z19ymf08YPPF89gJ7JeIj6YV?=
 =?us-ascii?Q?/l5oNQ6MZNy6KwGZVZnmRvnmv98r7NU1MHFkZQmqBPjW4Dn39GkpgwF+IgyJ?=
 =?us-ascii?Q?0kPJGKXcVx2F7ce5q0QiSvajU29xWWGaURl/J8s/eV8wowJbb3eqJtCHkvrA?=
 =?us-ascii?Q?o0G0oEyXzpbxQyWRgxmn1LLmzwMeCHe3YdBmoAiO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2456dd6-f87c-4b7a-8227-08db9cba58d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2023 11:33:57.0844
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uk535SdTUKYjSDZ8Hci38SvGnc1YazcZ0GKa5JLWhU1N+7HOmnKPSWHR5zVV696m46Xjz2hSRwwcCy/cZMdg2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3932
X-Proofpoint-GUID: _wjWdC6CqVKK7XdFBCVzet2K5rcnPOqA
X-Proofpoint-ORIG-GUID: _wjWdC6CqVKK7XdFBCVzet2K5rcnPOqA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-14_07,2023-08-10_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Saturday, August 12, 2023 3:35 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> richardcochran@gmail.com; Naveen Mamindlapalli
> <naveenm@marvell.com>
> Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp
> counter atomic update feature
>=20
> On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote:
> > > If you reorder the includes - maybe put them in alphabetical order?
> >
> > There are some structure definitions in rvu.h which are required in
> > ptp.h. So, re-ordering in alphabetical order will give compilation
> > issue.
>=20
> Headers should be self-contained. Such dependencies are hard to figure ou=
t
> for people doing refactoring so it'd be best to clean that up.

Ack, will fix the dependencies and keep the headers in alphabetical order i=
n V3 patch.

Thanks,
Sai