Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2529541rdg; Mon, 14 Aug 2023 05:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIeW2N6B5zHA3d7ERN15JRw96CXSAYn6YWsx/m7RU7isUWzVfVpyVbxBKzWdrhEXk2xZ8O X-Received: by 2002:aa7:d54e:0:b0:522:ab06:7213 with SMTP id u14-20020aa7d54e000000b00522ab067213mr6473746edr.27.1692016911230; Mon, 14 Aug 2023 05:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692016911; cv=none; d=google.com; s=arc-20160816; b=o6oGP9vPgSsBwQswNg0fLK2ti2GPJUZf3jgQhlp4hO68UzQjuop6xdSoAu+rn2t/qb RFe9tnBsS5E7jSq8PJK8PewgbSP3+kigTL5zPPOvwahI+Cr7G6g99i8lHdB/0PXPaJ45 OMYmJueDu+mFOIQqkZPYpTvp/8Ow/lNv4U7jE7xl4Rt+/wZeVxjfc7E2yKbM3ZrHcJHL VDO0pMaCauG+Yjy8REvL6LiOsbXRqhm72Bvt+b0i5Fw5cZ2VQETPP9sIWNzpaZxPMYmC IxP0V3z+CFig4L7D0gQB/GgXTA7DfoPDs1U2iOxcLimd5USov7tJAYklEHkR68KdLeGt 8WZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TXpw+9AlxegTAFzua86sCIHRPLxwX07oUCaO4xZ4CCU=; fh=aYRNNMJfLF0YOUsDQtINKzDTZJRAOjj9yaH5zD599Pc=; b=hFnDVddNUg8uzh+kEFhwtX+y5jQsIv2bo2RR0wcaVIWzy5YE9KadZg0m5jv2Xwdq+/ 7Y+gR+Lj4QJsHIIlN0wGn76O1rCM9+S+f3p+yAkwXS+LxX+W8ICfmjwvMKSgdYGLIXS3 nLWm31ejgz6BxOTd7pBw8kNRm/qyXar5K+nB33f+nJ0O+pU9HI6N+NtSkmy27tkOoomV 7L0MyoDOtSQAQBBg7GUpgTJEpqEefF4UzgV6byaBhXhVtgj3NXuu3XNRVXygya4RtLT6 kpiCt8G4NJmw+EU2Q+tv5/203NeafX0auJQeec41VfAMatket6+1Nij+YQ0VDc1j/E4p Ezyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ajPe0gO9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020aa7da96000000b0052322c44db3si8454199eds.678.2023.08.14.05.41.26; Mon, 14 Aug 2023 05:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ajPe0gO9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236108AbjHNKLE (ORCPT + 99 others); Mon, 14 Aug 2023 06:11:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236758AbjHNKKv (ORCPT ); Mon, 14 Aug 2023 06:10:51 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F010710C8 for ; Mon, 14 Aug 2023 03:10:37 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fe1e1142caso40920805e9.0 for ; Mon, 14 Aug 2023 03:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692007836; x=1692612636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TXpw+9AlxegTAFzua86sCIHRPLxwX07oUCaO4xZ4CCU=; b=ajPe0gO9yHcdleOA7GfZrRigrZ3bWfpSNzNqR1rOXEVtoFpu4/rC04EVdHoEMvI+dS +4SQ59Gkl+jHC+BF1Pe0sxewKBaQFs6Eb4Oe7ppEmHvAQK2epRWKpIcUSqwXP3X4oY3J v57p1PL7RSuE1pdSA9tLs06eALpNiNelU1w5h55JHara6wKJ4EvsGzpIiFs5MFjsBOg8 tgL+RnTmtVIyRiTkP7GVDTCa8MEu/s63REMJMgunvMC1SKcA1to0z6sV3ztBqZbhHEuK L6p7uvwD85TN0KbO8GWYm4CIr+0ubkYD1iif3TYVjeTOAW9/BuIS4r6VGaIxzZGD9vFz RGQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692007836; x=1692612636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TXpw+9AlxegTAFzua86sCIHRPLxwX07oUCaO4xZ4CCU=; b=B/GFX/dJMCmU7d6fYtZEhimtRuKX9wVbt7VRLU7WOx6FHY8oGKh0Q8Jz8UTMnUQJID gXN0VPaDvK0PHOwGnVD0T4J9DgAWWgphZbqUur7wdmSn2LPqf0vPVsEC26qbNaKKzCyE 0B/N/a3L0IpcQ9OvZz6+GTqKw5XCKPXraAZbuLVPlIaXXg4g9l2PUwhd/nRJOxHd2JE7 MSUiEjjKn1Jhsj9VVDovIT7fsYIH7KnmAbtBBvFV/4X1KkJ0FjvJTd6nRdboE9Oyohn8 bAi2tmPMakb/Id+23/toOabpv63BYuFRnWgTFgyujaEYiil8OuRMFQPatvvjF2kqdO+M ftXA== X-Gm-Message-State: AOJu0YzoJIQ7B/lSZJweMLYj9qhsaO7inEGfBWpLsYkbSqy7XzlkXUmr NrfFNXUC8BvmcXYxwIiXEMF74bdnHaM1Jud8SLU= X-Received: by 2002:a7b:cc1a:0:b0:3fe:2859:a7b1 with SMTP id f26-20020a7bcc1a000000b003fe2859a7b1mr7828426wmh.19.1692007836449; Mon, 14 Aug 2023 03:10:36 -0700 (PDT) Received: from hackbox.lan ([84.232.191.92]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c294500b003fbaade0735sm16750396wmd.19.2023.08.14.03.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 03:10:35 -0700 (PDT) From: Abel Vesa To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ahmad Fatoum Cc: Peng Fan , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: imx: composite-8m: fix clock pauses when set_rate would be a no-op Date: Mon, 14 Aug 2023 13:09:57 +0300 Message-Id: <169200755848.527063.16780652057592961020.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807082201.2332746-1-a.fatoum@pengutronix.de> References: <20230807082201.2332746-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Aug 2023 10:22:00 +0200, Ahmad Fatoum wrote: > Reconfiguring the clock divider to the exact same value is observed > on an i.MX8MN to often cause a longer than usual clock pause, probably > because the divider restarts counting whenever the register is rewritten. > > This issue doesn't show up normally, because the clock framework will > take care to not call set_rate when the clock rate is the same. > However, when we reconfigure an upstream clock, the common code will > call set_rate with the newly calculated rate on all children, e.g.: > > [...] Applied, thanks! [1/1] clk: imx: composite-8m: fix clock pauses when set_rate would be a no-op commit: 4dd432d985ef258e3bc436e568fba4b987b59171 Best regards, -- Abel Vesa