Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sriranjani P" <sriranjani.p@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <alexandre.torgue@foss.st.com>, <peppe.cavallaro@st.com>,
        <joabreu@synopsys.com>, <mcoquelin.stm32@gmail.com>
Cc:     <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <pankaj.dubey@samsung.com>,
        <alim.akhtar@samsung.com>, <ravi.patel@samsung.com>,
        "'Jayati Sahu'" <jayati.sahu@samsung.com>, <swathi.ks@samsung.com>
In-Reply-To: <2590a514-81f7-1876-c43b-80c8abe40cf9@linaro.org>
Subject: RE: [PATCH v2 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0
 Block of FSD SoC
Date:   Mon, 14 Aug 2023 15:48:44 +0530
Message-ID: <000001d9ce98$bbaedb90$330c92b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: en-in
Thread-Index: AQGL0eLTHe4L9QyPOdGPE73PwLZVZAJJY+tAAlLq9WAA4UOvEbBZlhdw
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230111075422.107173-1-sriranjani.p@samsung.com>
        <CGME20230111075450epcas5p3f13b94bfeaa66d386aa51f87ca4ec5bf@epcas5p3.samsung.com>
        <20230111075422.107173-4-sriranjani.p@samsung.com>
        <2590a514-81f7-1876-c43b-80c8abe40cf9@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 12 January 2023 15:05
> To: Sriranjani P <sriranjani.p=40samsung.com>; davem=40davemloft.net;
> edumazet=40google.com; kuba=40kernel.org; pabeni=40redhat.com;
> robh+dt=40kernel.org; krzysztof.kozlowski+dt=40linaro.org;
> alexandre.torgue=40foss.st.com; peppe.cavallaro=40st.com;
> joabreu=40synopsys.com; mcoquelin.stm32=40gmail.com
> Cc: netdev=40vger.kernel.org; devicetree=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; pankaj.dubey=40samsung.com;
> alim.akhtar=40samsung.com; ravi.patel=40samsung.com; Jayati Sahu
> <jayati.sahu=40samsung.com>
> Subject: Re: =5BPATCH v2 3/4=5D arm64: dts: fsd: Add Ethernet support for=
 FSYS0
> Block of FSD SoC
>=20
> On 11/01/2023 08:54, Sriranjani P wrote:
> > The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP,
> > one in FSYS0 block and other in PERIC block.
> >
> > Adds device tree node for Ethernet in FSYS0 Block and enables the same
> > for FSD platform.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey=40samsung.com>
> > Signed-off-by: Jayati Sahu <jayati.sahu=40samsung.com>
> > Signed-off-by: Sriranjani P <sriranjani.p=40samsung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd-evb.dts      =7C  9 ++++
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi =7C 56
> ++++++++++++++++++++++
> >  arch/arm64/boot/dts/tesla/fsd.dtsi         =7C 22 +++++++++
> >  3 files changed, 87 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > index 1db6ddf03f01..ca0c1a28d562 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > =40=40 -30,6 +30,15 =40=40
> >  	=7D;
> >  =7D;
> >
> > +&ethernet_0 =7B
> > +	status =3D =22okay=22;
> > +
> > +	fixed-link =7B
> > +		speed =3D <1000>;
> > +		full-duplex;
> > +	=7D;
> > +=7D;
> > +
> >  &fin_pll =7B
> >  	clock-frequency =3D <24000000>;
> >  =7D;
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > index d0abb9aa0e9e..7ccc0738a149 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > =40=40 -64,6 +64,62 =40=40
> >  		samsung,pin-pud =3D <FSD_PIN_PULL_NONE>;
> >  		samsung,pin-drv =3D <FSD_PIN_DRV_LV2>;
> >  	=7D;
> > +
> > +		eth0_tx_clk: eth0-tx-clk-pins =7B
>=20
> Wrong indentation.
Will fix in the next version.
>=20
> > +		samsung,pins =3D =22gpf0-0=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_DOWN>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_tx_data: eth0-tx-data-pins =7B
> > +		samsung,pins =3D =22gpf0-1=22, =22gpf0-2=22, =22gpf0-3=22, =22gpf0-4=
=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_UP>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_tx_ctrl: eth0-tx-ctrl-pins =7B
> > +		samsung,pins =3D =22gpf0-5=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_UP>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_phy_intr: eth0-phy-intr-pins =7B
> > +		samsung,pins =3D =22gpf0-6=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_NONE>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV4>;
> > +	=7D;
> > +
> > +	eth0_rx_clk: eth0-rx-clk-pins =7B
> > +		samsung,pins =3D =22gpf1-0=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_UP>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_rx_data: eth0-rx-data-pins =7B
> > +		samsung,pins =3D =22gpf1-1=22, =22gpf1-2=22, =22gpf1-3=22, =22gpf1-4=
=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_UP>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_rx_ctrl: eth0-rx-ctrl-pins =7B
> > +		samsung,pins =3D =22gpf1-5=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_UP>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV6>;
> > +	=7D;
> > +
> > +	eth0_mdio: eth0-mdio-pins =7B
> > +		samsung,pins =3D =22gpf1-6=22, =22gpf1-7=22;
> > +		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> > +		samsung,pin-pud =3D <FSD_PIN_PULL_NONE>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV4>;
> > +	=7D;
> >  =7D;
> >
> >  &pinctrl_peric =7B
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index f35bc5a288c2..ade707cc646b 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > =40=40 -32,6 +32,7 =40=40
> >  		spi0 =3D &spi_0;
> >  		spi1 =3D &spi_1;
> >  		spi2 =3D &spi_2;
> > +		eth0 =3D &ethernet_0;
>=20
> This is a friendly reminder during the review process.
>=20
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all reques=
ted
> changes or keep discussing them.
Sorry somehow I'm not able to find my previous mail chain.
I had replied to your comment in the previous version of the mail.
In this case alias id is used to differentiate between Ethernet instance 0 =
and 1 in the driver code.
>=20
> Thank you.
>=20
>=20
> Best regards,
> Krzysztof