Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp2573752rdg; Mon, 14 Aug 2023 06:59:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmMGzrVNZWG29f0AMFvOQ6jfw+5yVVIVZyga3FpI8//3kZM94k4qB1xr13y7FhIlo3Cmab X-Received: by 2002:a05:6808:201d:b0:3a7:3707:242d with SMTP id q29-20020a056808201d00b003a73707242dmr10966763oiw.30.1692021580154; Mon, 14 Aug 2023 06:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692021580; cv=none; d=google.com; s=arc-20160816; b=Yrnr+3n0P4Zof5AZ0419Ou9ZEh/gWOxDWfjXe8t/pEDQJaALomOIdhyXhzDoVPrG/v 1jwyLDdUiLbzv3VRckIv990eArqu5dkm9+2cxlNN1rt+KMaMDDUCOjXcZqU6GSMoufF3 kxjw/qrz7EV8ieRfsPHqoJbRNo63J6A50rGICPKGK3nnqLBTdHkjsX4/VMemwb5vW9k3 dsTh4TbGtEt/DnJjPu1oq/QVCo1m080ggTVJiHzYv5PVr+Fr+tCzOZ5jGvq32Dk6htbK Xm/THkSHeK/iDKi1rBb7L/t6rns20KVNZrWYAaTJQJhQIdF0nDSLwTNhOZKr5Vs+J09g Xwyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=t7icBauJBJbjfgpWzY440IllQTVH/6HK+tv6+c4cYTw=; fh=c1apOeYxXr6VSXIVUjbHOAOg3c/zg9Yp9lR2FTQ0Yko=; b=SbdcxBZfIaNoPkL2qr/PE/yiG/TqeO8nhKoZk83szthRNkoAqvEGZvliqCqu/p9+WJ FJG9+FSm/R32NX98gOIbp5GcE/OmrcSY6JtRrY91leJ5QKwNxYAQaB/jQRFD8t3geCly U/XQ61pBgLrpLczTwb41vWGXJqsFQ4DGcsEE5D+rzYuo9coLZtVbi+gDnCxPIzuMN9Yk k8/HTge1vx/qLg5+U1TdmpLQHdCWFsGE3o0t4jCdypna8GQzLB6cpHMm0JlniCD5CPr3 NYIj6o31mlyVS5I0kaM/FU7pzdlgpR+NKJD0xcqqsnkea3wTpob9Rh4X8EZb6l5NoVTr rrPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q0G/P5u6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a634c10000000b0056418f28df6si7789277pga.838.2023.08.14.06.59.28; Mon, 14 Aug 2023 06:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="q0G/P5u6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231367AbjHNNic (ORCPT + 99 others); Mon, 14 Aug 2023 09:38:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbjHNNiN (ORCPT ); Mon, 14 Aug 2023 09:38:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87343106; Mon, 14 Aug 2023 06:38:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1CBB8616F0; Mon, 14 Aug 2023 13:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04BAEC433C8; Mon, 14 Aug 2023 13:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692020291; bh=t7icBauJBJbjfgpWzY440IllQTVH/6HK+tv6+c4cYTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q0G/P5u601yj55RWvw2gClmvEfBdOUAylS2eaRLXMus/fyWigWFE/GpQ+DPUHUq58 pPY0V/OeQctjK9hIm8mykfKxY7nQELOSlN0SE5secLkkz0HscZWs6J9h+qgEi9ikuL rLXBBo0QzDBJP472uNaAXVb0QlMrqHN4deU643CFXjldoAo+aTE9jyLGjyJtmhpWkt k+XGFNuqRn9NG/x7Goxg2DzxkPUTKozm4Eidij2eB4/Lqhvib5IhtDANNspTQFacFg 9islMXR565w6J62g6e4ryznnSXTIpsRt0m1lH5BBt3vQQ6tEZYU5/VrIhhzSPjV+bY ybjdWQDrjzTbw== Date: Mon, 14 Aug 2023 15:38:08 +0200 From: Wolfram Sang To: Parker Newman Cc: Laxman Dewangan , Dmitry Osipenko , Andi Shyti , Thierry Reding , Jonathan Hunter , "linux-i2c@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing Message-ID: Mail-Followup-To: Wolfram Sang , Parker Newman , Laxman Dewangan , Dmitry Osipenko , Andi Shyti , Thierry Reding , Jonathan Hunter , "linux-i2c@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Db4jKuiAS4AKOy/g" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Db4jKuiAS4AKOy/g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 03, 2023 at 05:10:02PM +0000, Parker Newman wrote: >=20 > This patch fixes the Tegra DMA config option processing in the > i2c-tegra driver. >=20 > Tegra processors prior to Tegra186 used APB DMA for I2C requiring > CONFIG_TEGRA20_APB_DMA=3Dy while Tegra186 and later use GPC DMA requiring > CONFIG_TEGRA186_GPC_DMA=3Dy. >=20 > The check for if the processor uses APB DMA is inverted and so the wrong > DMA config options are checked. >=20 > This means if CONFIG_TEGRA20_APB_DMA=3Dy but CONFIG_TEGRA186_GPC_DMA=3Dn > with a Tegra186 or later processor the driver will incorrectly think DMA = is > enabled and attempt to request DMA channels that will never be availible, > leaving the driver in a perpetual EPROBE_DEFER state. >=20 > Signed-off-by: Parker Newman Applied to for-current, thanks! --Db4jKuiAS4AKOy/g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTaLkAACgkQFA3kzBSg KbbFJg/+NI5XqMJpKaWLfSatM0gW6FIo79Uim8p8ap/55ijuzAnBVsl4x4Ue//L5 +ebfAQ65hOS5P8+08RR7IdRuAD6iTAOHSXHE/Fj5Yvs+VKI847lxcSNQ5T2k6ori pycBnmAkolhNU8TLMsSyJEheOmeBfPzyLKmc6p2DxmTokltKA2C92IABycFCaNPC yVuPx0pKsotWyk7ANA28n7nQyZA+5RQn2+oUo5ZgGLZTuMM52FQEDGF8lSbVuaOl nLkoBmmgTZJDizNBcjydYDWGowzoLxHtwHGTAkmQv17GmM2sPb8EMWNkC2HW9GLD M4jNdgm9BQuoFnHzggmtKLT5XE3myCcx8zq/0ldO4MUGwteS3PuwTj8l0jsX062N pPca3Tv02FI3q4YQ8rfR2aupqpfxT7MpLF3Jfv/LTGhpKXRr6mnFda8xq3OAIixP sISl4p3ztVk6h3dOtUI6mqaIKsiUImB3Inus28K1L+SPz0bnmPdcUPhXpzlWpY1p oUOVUyEMNVXCzXP+W5UYmQyfxokOUNwhPNjk9MqhSChsjsoupmUcEp8eWJkUYaDg iwvmyT5tqyPwMZ/I8LPgxw6QX8nRqRwH+TJwByW6MiUpZiwmUWCgeMB+ZLwFFwVq rL0CrMnOA1jxSYjaPctiAdC9A6KXk3r4FPxQ1jEkKygDWCxx9rM= =+wNa -----END PGP SIGNATURE----- --Db4jKuiAS4AKOy/g--