Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230813160936.1082758-1-sashal@kernel.org> <20230813160936.1082758-22-sashal@kernel.org>
In-Reply-To: <20230813160936.1082758-22-sashal@kernel.org>
From:   Ilya Dryomov <idryomov@gmail.com>
Date:   Mon, 14 Aug 2023 15:23:41 +0200
Message-ID: <CAOi1vP-+xfmQBNWL4iKC+bB-T+yjPh=zF0nBqGMeXCdvpf7+zg@mail.gmail.com>
Subject: Re: [PATCH AUTOSEL 5.10 22/25] rbd: make get_lock_owner_info() return
 a single locker or NULL
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Dongsheng Yang <dongsheng.yang@easystack.cn>, axboe@kernel.dk,
        ceph-devel@vger.kernel.org, linux-block@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Aug 13, 2023 at 6:11=E2=80=AFPM Sasha Levin <sashal@kernel.org> wro=
te:
>
> From: Ilya Dryomov <idryomov@gmail.com>
>
> [ Upstream commit f38cb9d9c2045dad16eead4a2e1aedfddd94603b ]
>
> Make the "num_lockers can be only 0 or 1" assumption explicit and
> simplify the API by getting rid of output parameters in preparation
> for calling get_lock_owner_info() twice before blocklisting.
>
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Hi Sasha,

This is a prerequisite patch, it doesn't make sense to backport it
without also backporting "rbd: harden get_lock_owner_info() a bit" and
"rbd: retrieve and check lock owner twice before blocklisting".

Please drop it.

Thanks,

                Ilya