Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 15:29:32 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
Cc:     linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        patches@amperecomputing.com, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        jsd@semihalf.com, chuong@os.amperecomputing.com,
        darren@os.amperecomputing.com,
        Quan Nguyen <quan@os.amperecomputing.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: designware: Correct length byte validation
 logic
Message-ID: <ZNosPK3M4/bZ0vc9@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Tam Nguyen <tamnguyenchi@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        patches@amperecomputing.com, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        jsd@semihalf.com, chuong@os.amperecomputing.com,
        darren@os.amperecomputing.com,
        Quan Nguyen <quan@os.amperecomputing.com>, stable@vger.kernel.org
References: <20230726080001.337353-1-tamnguyenchi@os.amperecomputing.com>
 <20230726080001.337353-2-tamnguyenchi@os.amperecomputing.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Va0SrhCIqzaABToJ"
Content-Disposition: inline
In-Reply-To: <20230726080001.337353-2-tamnguyenchi@os.amperecomputing.com>
Precedence: bulk


--Va0SrhCIqzaABToJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 26, 2023 at 03:00:00PM +0700, Tam Nguyen wrote:
> From: Quan Nguyen <quan@os.amperecomputing.com>
>=20
> Commit 0daede80f870 ("i2c: designware: Convert driver to using regmap API=
")
> changes the logic to validate the whole 32-bit return value of
> DW_IC_DATA_CMD register instead of 8-bit LSB without reason.
>=20
> Later, commit f53f15ba5a85 ("i2c: designware: Get right data length"),
> introduced partial fix but not enough because the "tmp > 0" still test
> tmp as 32-bit value and is wrong in case the IC_DATA_CMD[11] is set.
>=20
> Revert the logic to just before commit 0daede80f870
> ("i2c: designware: Convert driver to using regmap API").
>=20
> Fixes: f53f15ba5a85 ("i2c: designware: Get right data length")
> Fixes: 0daede80f870 ("i2c: designware: Convert driver to using regmap API=
")
> Cc: stable@vger.kernel.org
> Signed-off-by: Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>

Applied to for-current, thanks!


--Va0SrhCIqzaABToJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTaLDwACgkQFA3kzBSg
Kbbh6g//azQ4qtqndnhpbxP1Ujc5PyG55chGeQ7kmcTlXpJaZEJq/rTc7y/HbNGG
6/kIeriOMA2BU4xJKk6ipIK8OiM5Kk8WD6ow7LhICxzi4xg2CAy+ILTiaWnflUtn
XGW6GNFx02+iiHwv3Dfek5CJ9NF/Kk4CSw3EV9umFT1GPzbCtGLSfX69BW7Abbod
o3vLeUu5y7P56RYotEjUJPIrM961G/pnPh0p29EkJkFmg/6rdy1bS6FSilT8KgyN
uLlxqJiSBu1yRJTmPE2wPKlppfNmtCg1VojbDsZaJN9PUxqF/m4+uh6//1spj1O0
2lh5t/YkbdBAT7u7JH2OuaveQIssgaPFRkt9I9ugda1kAvCeEjBAYVL5wyvIm0mi
kvHk+2x1HizQfOCRxIWAlEvz3IT1PSjQQ2Daqg1FFSD96jay/6gcFXnkQBXSbVWW
oiumMrTwHm8yT1uzfN2Srd9j1/OOAnckxC4VPjoMcEv1sPBb9sohssNdMF1Bgzoi
h2L0thsS4lHgP3KzCAczSpmOT4kbW71h4WMQli2wCnU1fTGyhHX/2GjblEefqyrE
8o7hTZedd00qhzeKCGZKE+2UuQL6uqKqGaqcv2HviOIu8g3MYThkam3Kr/WQsSov
//P69PLYuat/fBbVrM5r7AdreNgcLcYuc73L2NlPqnJmneNWQew=
=cdP5
-----END PGP SIGNATURE-----

--Va0SrhCIqzaABToJ--