Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 18:32:01 +0530
From:   Pavan Bobba <opensource206@gmail.com>
To:     Julia Lawall <julia.lawall@inria.fr>,
        Forest Bond <forest@alittletooquiet.net>,
        Michael Straube <straube.linux@gmail.com>,
        Philipp Hortmann <philipp.g.hortmann@gmail.com>,
        outreachy@lists.linux.dev
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case
Message-ID: <ZNolyVLwygowAzE2@ubuntu.myguest.virtualbox.org>
References: <ZNOK2u1sJoRAxhIC@ubuntu.myguest.virtualbox.org>
 <2023081150-hamster-sulfide-4231@gregkh>
 <ZNfPiQAL3ixA7tjz@ubuntu.myguest.virtualbox.org>
 <alpine.DEB.2.22.394.2308122041160.3315@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2308122041160.3315@hadrien>
Precedence: bulk

On Sat, Aug 12, 2023 at 08:41:51PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 12 Aug 2023, Pavan Bobba wrote:
> 
> > On Fri, Aug 11, 2023 at 11:27:10PM +0200, Greg KH wrote:
> > > On Wed, Aug 09, 2023 at 06:17:22PM +0530, Pavan Bobba wrote:
> > > > Replace array name of camel case by snake case. Issue found
> > > > by checkpatch
> > > >
> > > > Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> > > > ---
> > > >  v1 -> v2: 1. array name renamed from byVT3253B0_RFMD to by_vt3253b0_rfmd
> > > >            2. typo in the subject line "small case" corrected with the
> > > >               proper word "snake case"
> > > >
> > > > Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> > > > ---
> > > >  drivers/staging/vt6655/baseband.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> > > > index 0e135af8316b..cc8793256661 100644
> > > > --- a/drivers/staging/vt6655/baseband.c
> > > > +++ b/drivers/staging/vt6655/baseband.c
> > > > @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] =
> > > >  };
> > > >
> > > >  #define CB_VT3253B0_INIT_FOR_RFMD 256
> > > > -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
> > > > +static const unsigned char by_vt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {
> > >
> > > Again, the "by" needs to just be dropped.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > hi greg...did'nt get your comment. can you please provide more elaborate
> > info?
> 
> Drop the letter "by_" at the beginning of the function name.  It is there
> ot indicate the type, which isn't done in the kernel.
> 
> julia

this is'nt a function name but an array name. is in't it fine?