Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp1677rdb; Mon, 14 Aug 2023 07:56:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxA+dgnfJgFJ7oN4QITzppW1FT5SwGfI3KrNfla8GmGH2sD8yjk30FCGI8MMysqjST/OuO X-Received: by 2002:a05:6808:11ce:b0:3a7:f153:cb35 with SMTP id p14-20020a05680811ce00b003a7f153cb35mr9212503oiv.22.1692024969989; Mon, 14 Aug 2023 07:56:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692024969; cv=none; d=google.com; s=arc-20160816; b=JJwIyn8S7eDPx3axf0/THvwbulTICE+lJU3AipZ+ymHDMnKqdyq6pfW6WkxiS6TXRf Y90o/SL/KmesHxbeglMHxuyM893nPeO7MlrqSf5/xMyCfxZUCRkK0T9EAr2aTpYDYZHV r6UlqTU/BRxyxOULmO3bVeeMhQbZTPefp5ojjllEo52Earo+48ZzNW8jf+b5B0801X7P th8gCjh0cDh4EQUCEBEuuL4orIeeFR+A1z+v7pnaQwxkwVsas62gfUsqu0X98pLuNMjE mSnkSejKdn9nFRvn/ML1FkTw4LNWOMTFr+dloMK6QcOpzNXdOQi4PsBy7wgugDN2aMZI GnDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4W80DDZNGe/khXLl1P1oJD7Ws9Jxxl4GH65wXpEW+I0=; fh=//zu3PsYWOPpkr/3y2P26yPUiLWhB+hLSpKnMYGDkzw=; b=qVlEjqc8yz3hsMlN9nDn6nS7oW0V8DvF9B0cIhTcuN4aXx5BWGglghwNr4arf6I2km vkp1GIc+a4L+I5beMetWxeZt0mRCcMEHjvnK7xOnAox37bG8Wte+L4RMy5K/9YaeZf8V e6QZoYT/YdIKyXYvI+9Jnbv6JjIEzeZQt+TUXcBOCkktEqqbOBvmq9FWxGf+ABrOVCLj Z+4K7cBTqIfZc+P+yND4QL7QTyZjyCUzAIx1H+Lumd2UXHpGt8mLOdfEitjxLc73P76o vFVrMvok97PW4HEev8uyqrXLpCJyufPptt/ndOXeNH7APkHIU/YY6IlMxUJRFrse9lfY oing== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hENwvV60; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a630c0a000000b00563ef54582bsi8087188pgl.105.2023.08.14.07.55.58; Mon, 14 Aug 2023 07:56:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hENwvV60; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232071AbjHNOKs (ORCPT + 99 others); Mon, 14 Aug 2023 10:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231946AbjHNOKX (ORCPT ); Mon, 14 Aug 2023 10:10:23 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B4C10C1 for ; Mon, 14 Aug 2023 07:10:21 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fe4ad22e36so40436205e9.2 for ; Mon, 14 Aug 2023 07:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692022220; x=1692627020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4W80DDZNGe/khXLl1P1oJD7Ws9Jxxl4GH65wXpEW+I0=; b=hENwvV609a0ekk68nFeJgCMLFglZamjuMITKMPh+IleT4oSy59pqLdXoXwilgJNP8I LbafQe1WNSjwEMF5jHGg5XmL5/Bq9b30ZcUNXKGg1rhqGatzedGkIqbuzDVM7aCHYLAd TB/L8fLr05QGnXKgS3k+NS5KbA3CsS3d5mK7vaRkSqHNqVPWLXB08l7mSD0GZ2102Oyt 0+7Gzk9EXCh2m4cSn0jdoywxrjeXy5LHnuI0Yd0pAwciPQRK65DT9KXqU/J6KywoZgc9 IVaqQ1wyzH0FMWd1DvawM443XHTcY37QTmYTqaoJAf4WcsNTBHvqfofSBZ2h18dfZf89 7jKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692022220; x=1692627020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4W80DDZNGe/khXLl1P1oJD7Ws9Jxxl4GH65wXpEW+I0=; b=aPcortty1hPP9a7auDtm9vVeWnuVsP9Euxvxbrh+GKiV3VFdPl363pTDw/y9ouMl47 Rp+4NUlJy09q+xMmYiYTxpNxWoPbhU7GktUeh3DON13jNmgyyTFTFmJXMU9Y/DRJYB3c wOnWaXBqRAgV+m8ggoS9FsMMXxhjDHX/uMlNKk2TPEixyuJz40W4BIl4lC6PgWDfldKG Y8di6zTSbMsLaXl2Y/1W7kR9wshprRzm4Oj1RkpEbGYmFDODc+Gg+qtW4o4sIGRvyyPe hLr/v51DjmxOwKEPjAKYrLKDqCY/p9CVeT/d4PVNbfnkqUdOf6gn/eqyfpojSWJNC+gC jr3A== X-Gm-Message-State: AOJu0YxXTZ5okuIdH3zJhvRwfMPIwNAGAXPUsUnV8Ls3NkO0NPlf0RPn YpGfRRibQy19ZAULtkFmrBNwAQ== X-Received: by 2002:a1c:7c05:0:b0:3fb:e58c:7758 with SMTP id x5-20020a1c7c05000000b003fbe58c7758mr7439167wmc.3.1692022219725; Mon, 14 Aug 2023 07:10:19 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id p5-20020a1c7405000000b003fe1630a8f0sm17232749wmc.24.2023.08.14.07.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 07:10:19 -0700 (PDT) From: Bryan O'Donoghue To: rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v0 6/9] media: qcom: camss: Fix missing vfe_lite clocks check Date: Mon, 14 Aug 2023 15:10:04 +0100 Message-ID: <20230814141007.3721197-7-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230814141007.3721197-1-bryan.odonoghue@linaro.org> References: <20230814141007.3721197-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org check_clock doesn't account for vfe_lite which means that vfe_lite will never get validated by this routine. Add the clock name to the expected set to remediate. Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 938f373bcd1fd..b021f81cef123 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -535,7 +535,8 @@ static int vfe_check_clock_rates(struct vfe_device *vfe) struct camss_clock *clock = &vfe->clock[i]; if (!strcmp(clock->name, "vfe0") || - !strcmp(clock->name, "vfe1")) { + !strcmp(clock->name, "vfe1") || + !strcmp(clock->name, "vfe_lite")) { u64 min_rate = 0; unsigned long rate; -- 2.41.0