Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Josua Mayer <josua@solid-run.com>
To:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Josua Mayer <josua@solid-run.com>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH v2] net: sfp: handle 100G/25G active optical cables in sfp_parse_support
Date:   Mon, 14 Aug 2023 16:17:39 +0200
Message-Id: <20230814141739.25552-1-josua@solid-run.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AUhlucghsBfd6la7n2F/OQIWpQQCBJphjjcjeFemSLCLim2VoEijbC4v+yKn?=
 =?us-ascii?Q?lPMWtZ8nViKk05JR0kB7WO8TxNWG7c8jJl2lZQw1ae98V7pWcwf2Qslv8Zxc?=
 =?us-ascii?Q?O7J6gr1IOVuhNCM5n+VM0grIxb0PSal/jnbnIgb9ELM7azJwAPBSoYO6s7ae?=
 =?us-ascii?Q?9hrXPpVPqQYVX6HCIFMVsT8bnDePm6kfGsDAiVaavbDzlYrH5rLNfPWhk5Ya?=
 =?us-ascii?Q?Z2YsCxXCZZwxXGJm2NnkFxvsKEHJCLyHRPLwFZjEYXp3/Yt5KTADljxaIOPh?=
 =?us-ascii?Q?0DVmyB3gNE7gL3ogSMSURivxQHOkosGgIM3320RtHqg7+wUr5ZSw/+ifiVXk?=
 =?us-ascii?Q?As+ptZCXi2fq8aAZbUXjRKqlMGGWFZTT4qHHyrFjR0thCC4pg5rXH+Djly1D?=
 =?us-ascii?Q?NnasO7YHIlcEHb+bpC2hdbMtz5P99W3L5dwiGIPHQxb74ZzKvJLUkVfjQEqS?=
 =?us-ascii?Q?YNkt7cSJPBc4HBN3dzstdJNpHR6TI5s4UbYwbjfWnFp5ZGx29KIDkxOpMmMl?=
 =?us-ascii?Q?Fx7C8ktZfeBZRBwA73ksu/jyCLaHIFXeeOY+jwiSZSf4v9CBXW0pMhVm097B?=
 =?us-ascii?Q?CkDRyks8ZI+w86DEB/FzCa4yVIcGolc8mOHaKWTqcN4KBevA9H8e6oRjf1DA?=
 =?us-ascii?Q?D8NwVqEXkOVByNjZFzpRQM5ILE8qzjCbqe8birQPh4A71Dr6nbILauN+PWEv?=
 =?us-ascii?Q?Xx357zlEEImNoXEN6uoImF37zWuFkX2VuRdsghSabiO4w3dv60P5/C64XM+0?=
 =?us-ascii?Q?PibVlLWyVqrk2/sCbJHuKDa1XN6A8mKffO80Ddpuy6Nn1AXu5oXoys4lYU+X?=
 =?us-ascii?Q?WfeJ0Tzpp1pBP3nJ0OBP77r640BaeYb9N/+nKV/VH5wiCqGrTv+3deIOC6SI?=
 =?us-ascii?Q?eYL64JZmrx2fTJ6yZ1f9kJStFgA9rlfMhEG6hmIzIjMyRriO8SB24DMItVV4?=
 =?us-ascii?Q?DRHGvjgxJ4bnLNZBK/h6HBcrc69x51ux8AyBz0rzA5S9ZJ5qOPNqSxcUOXd3?=
 =?us-ascii?Q?4hgzCGrp1S2+OS8Sa93ZRTlXDKSNPz0ZvdBkL9sXu0U8gjPpUhd8L4QxAUHO?=
 =?us-ascii?Q?4gcxU0WqQV2PlEBcIJlwjU7MmjQ9dWcPZDjAmZG1y+G2+gIH1I1sbx3P1kuT?=
 =?us-ascii?Q?KzUqAeJ+B5cc2JiAJudqxjB5vQpqKj84VYa3uwToN+7lfzSxYE1r0A31Vf2t?=
 =?us-ascii?Q?E4KtKQR4c1IavHosdFOmI2F+wiRMKXNhRsy2eDrrl2WPnNdvVTS59adbsx3W?=
 =?us-ascii?Q?FW/b0KQsYqt3niwI5VSbDOjcZTR47U7ArC/n5JyeOF/uD3kOgq3Oun9LFRWE?=
 =?us-ascii?Q?UwAKxxfzsar/MoqPqKlphJFzqJM0b4im0DEjAYudr7G0XYdq+wkK94o0Ci6I?=
 =?us-ascii?Q?9hhxoyb8OsoGP+yAbUfbbYcl3PL/kNPTqPGhr+7zhequTfhbchjogztYkSkz?=
 =?us-ascii?Q?cmpbaAtIjy5zPCThrrANXR7hrLouvfVAt3XGh23T5IaZ/GKDc9SZj6a+S2/y?=
 =?us-ascii?Q?j+mmFWqFH3e7AW8IcilH86x9ZdWOiaclPbsX7wEiOaeS2LfSZ1N4k0W3zbPs?=
 =?us-ascii?Q?7fCplcaJilg+W8Tn7IKzjQoA40/BzZ7t8WeV3BHo?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bf76397-e20e-4f30-0798-08db9cd330e9
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 14:31:47.7640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: trZZM+HIEaXj4yl7erMHPZ21CCfDuE/g2qN6rEk9HKRnQhYEnR+RtBc3sPfKnOr8/uY4pJj7x5VpO910acOGBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9216
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Handle extended compliance code 0x1 (SFF8024_ECC_100G_25GAUI_C2M_AOC)
for active optical cables supporting 25G and 100G speeds.

Since the specification makes no statement about transmitter range, and
as the specific sfp module that had been tested features only 2m fiber -
short-range (SR) modes are selected.

The 100G speed is irrelevant because it would require multiple fibers /
multiple SFP28 modules combined under one netdev.
sfp-bus.c only handles a single module per netdev, so only 25Gbps modes
are selected.

sfp_parse_support already handles SFF8024_ECC_100GBASE_SR4_25GBASE_SR
with compatible properties, however that entry is a contradiction in
itself since with SFP(28) 100GBASE_SR4 is impossible - that would likely
be a mode for qsfp modules only.

Add a case for SFF8024_ECC_100G_25GAUI_C2M_AOC selecting 25gbase-r
interface mode and 25000baseSR link mode.
Also enforce SFP28 bitrate limits on the values read from sfp eeprom as
requested by Russell King.

Tested with fs.com S28-AO02 AOC SFP28 module.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
V1 -> V2: added separate case SFF8024_ECC_100G_25GAUI_C2M_AOC
V1 -> V2: added bitrate check for eeprom values

 drivers/net/phy/sfp-bus.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
index e8dd47bffe43..a4b0bb50e2eb 100644
--- a/drivers/net/phy/sfp-bus.c
+++ b/drivers/net/phy/sfp-bus.c
@@ -258,6 +258,17 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
 	switch (id->base.extended_cc) {
 	case SFF8024_ECC_UNSPEC:
 		break;
+	case SFF8024_ECC_100G_25GAUI_C2M_AOC:
+		if (br_min <= 28000 && br_max >= 25000) {
+			/* 25GBASE-R, possibly with FEC */
+			__set_bit(PHY_INTERFACE_MODE_25GBASER, interfaces);
+			/*
+			 * There is currently no link mode for 25000base
+			 * with unspecified range, reuse SR.
+			 */
+			phylink_set(modes, 25000baseSR_Full);
+		}
+		break;
 	case SFF8024_ECC_100GBASE_SR4_25GBASE_SR:
 		phylink_set(modes, 100000baseSR4_Full);
 		phylink_set(modes, 25000baseSR_Full);
-- 
2.35.3