Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22fdba99-8af2-fb3b-a208-a9bc1eab317c@intel.com>
Date:   Mon, 14 Aug 2023 08:18:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH -next] dmaengine: idxd: Remove unused declarations
To:     Yue Haibing <yuehaibing@huawei.com>, <fenghua.yu@intel.com>,
        <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230814135952.12892-1-yuehaibing@huawei.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230814135952.12892-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEdEOUR5b1piZ2pyZE5EeWl4L00vbEZYamljQUxtQkVuS003Szd3OUNLYnFC?=
 =?utf-8?B?dWVrRWhCWkRyRU1vcEdFNVVxQWJ4STlOblVCSU9rKzd3WEE3Uk8xZVF0ZmMx?=
 =?utf-8?B?RkFxKy9HL1Z1Z0d3b1Arc3RtbCs1MzdZbnJEMXRtT016WTdWYnZseUVSZWsx?=
 =?utf-8?B?Sng0RDV4VkxaUmVnSnhsUjZYK0xkRkhDMXB2Y2pEUHY5RkdyaDZ3SXRZMjgr?=
 =?utf-8?B?WUpWUmlEaG1LRUtZWmJDZlQ5bzl2c2ZoQjRIU0NGNDJ4QjJPN3pEWUF0Mi9S?=
 =?utf-8?B?TUlvY0NBZW1aSFpmbGEvSE44dlFpRElocm1HeUcxaURyYWRlTVpuMStQenlv?=
 =?utf-8?B?QXFpYmF2WElJOHJNVnRHcGx3UHR6VmZJdlpzQm9VU3RqYkJKQTlSZjJwelFJ?=
 =?utf-8?B?N2h6QTFreEhNV0hIZGF1WHl2RlZIcFBha0g0bE5mZU5FVVNieFZTa3J0ZVFo?=
 =?utf-8?B?SmRIaXUxdWl5d1paUGtqRW8yQlA0cWNsSXRnUXkxdHJ0ZVBLeC9RYnQ0c0Fh?=
 =?utf-8?B?Rmw5SGNZcERHcFBPREVXOWs3cWFKYXdFVlVacjNkcFVlTHZtUjc2ZkE4K3ZI?=
 =?utf-8?B?MzJJYURaS1k0a1BDQktEZnBTU1M5YjNzSDRVaCtTV0NSRFNTNElvR3M2dXhi?=
 =?utf-8?B?b2pzQjVwcWNaU2M0Mk8wTHZLY0VFVXVuZHBhczN4ellCWE96c1ZUWE5JbmE4?=
 =?utf-8?B?YVExN3ZzNGtYNFZ2bEZMYTFTY2RiOXhlN0cxRWRPb0RWZ1FmdDRMOTRKRnFI?=
 =?utf-8?B?WWt4Y0hWVzlNaWh0MHpibzJkL1pCNTNPeUdqWFlFYW12aHJybnVTdk5VQlRC?=
 =?utf-8?B?KzNOZlZ2aTUxbXdCenZtMEpKS1piaTBVYXpwMmNZemtubUloTWNMNGlNcVIw?=
 =?utf-8?B?VDk2OUNFck5OY2Evamh0RTd0cWdNT3BXWGFTelExMVdUWFdyQTk5dEY0V3Fv?=
 =?utf-8?B?bjdsV0txYS9wYWZBQnZQOWhvclJBTU00TUtaOXhFbVBuZW9KOTZnbnpISExa?=
 =?utf-8?B?a0ZSVS95Y0xlUCtnc3dKNUZQUzUyalhmQUtxRHpsRStlNUI0NW5ITmtwWWxU?=
 =?utf-8?B?MDJ4U1lNV2NsSzFRK2dGVWhNYnBwSnNzcWhjczUraHNWSSsyQWtxUXNXeUc4?=
 =?utf-8?B?Q0o3OTRKaU1vYUsxMXdDd2lkVTR1MzcxYnJCWEw3NnVzSzZzVURMbDcwM2li?=
 =?utf-8?B?SmRwOXpHMCtDMzkrNUFNSUV4OTFFMm91ekpCVjVkSExnNU9kNDZ6QlNFalNk?=
 =?utf-8?B?REV3L2tkOW1ZeldpZCtUanBBNDM0Tm4wcDNLaVdjM3JYVThEYnF4dWNPRXkv?=
 =?utf-8?B?NGNuRFp5T1lYclRGVkhUWHFxaENnU01yT0RKcFZldWI1YitsRkdoTUprL2ZW?=
 =?utf-8?B?TmpXSWw3dmhnTWc4ZVN1bndkVVFNdGNDQ2tZaWdnMmRQcklmZVNiME1pRC92?=
 =?utf-8?B?YUpkejBIMm1yYWttRlEzM2hZdG1yaUwva2ZhdUZqdlJ4K0hKaklLQlNCZTNX?=
 =?utf-8?B?bkJZdzhkT3FSQjFOY3BOaXRMaU1acmIyejFDWGNsbERhOVZDdVZJdVNtekhH?=
 =?utf-8?B?WGpBTGFjY29QemVzbnU2QlBBcDhTYVEvclA1b0JLU1BYUXRSK3djMmNBMzZ1?=
 =?utf-8?B?RTBGN2VRWk16R3k4UWZldGhNZzVzbEdadDhncGluYlJVWkloVHZtY2ltSktD?=
 =?utf-8?B?VmMySm1oUWtxUWMwT1pFWmtTYTlKVGIzWVdaZ25tYmt4NTRlYS9BWHVhUlRs?=
 =?utf-8?B?VjN6cmhlUHhwWFpyMElWMTNRU0xpUHhPTFZMaHZiNi9yMkpaenArR3k2Nks5?=
 =?utf-8?B?TVFIZmhySVM2NGptbWxTWkxlYmY5QVczMlB1MmZzSDR5RDBaZ3g3QWh4QjZz?=
 =?utf-8?B?R002ZkExclFxYWFmVUdjUUcyU2VrdG1ib1ovZVJKclVzOVFpVXRMRTdZcFEy?=
 =?utf-8?B?QVVQM09USW1JRm4rYUZwWjV0NlR6Tk1naG9WK2JDV2lEd1lyamtRK1NlbXJY?=
 =?utf-8?B?QmViZmdxU2hSckVFY1BWR3pBdHlsV1ovU1U0dWt2dHhCUko1dVllU2NEek5x?=
 =?utf-8?B?NjV4QjNmRWZwZEJwTFlJYU96WHJCVmozSkovOWZaOFR4VUJVcWdhemJ6M2ZH?=
 =?utf-8?Q?pc5jcriAqmHCUqrmtu/aD3NtQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98d46f6e-e710-4214-1a67-08db9cd9a7dc
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 15:18:04.2873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ktr5vGTmXhaIGUZcRDwm5w+CKpEv456iku5C2R8pfWo6IV+FBz1GlEpN6y1o46v1C1MmaFVAjwD2Rzj5NpAaYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6192
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/14/23 06:59, Yue Haibing wrote:
> Commit c05257b5600b ("dmanegine: idxd: open code the dsa_drv registration")
> removed idxd_{un}register_driver() but not the declarations.
> Commit 034b3290ba25 ("dmaengine: idxd: create idxd_device sub-driver")
> declared idxd_{un}register_idxd_drv() but never implemented.
> Commit 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine subsystem")
> declared idxd_parse_completion_status() but never implemented.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thanks for the cleanup.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   drivers/dma/idxd/idxd.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 5428a2e1b1ec..05a83359def9 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -651,8 +651,6 @@ int idxd_register_bus_type(void);
>   void idxd_unregister_bus_type(void);
>   int idxd_register_devices(struct idxd_device *idxd);
>   void idxd_unregister_devices(struct idxd_device *idxd);
> -int idxd_register_driver(void);
> -void idxd_unregister_driver(void);
>   void idxd_wqs_quiesce(struct idxd_device *idxd);
>   bool idxd_queue_int_handle_resubmit(struct idxd_desc *desc);
>   void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count);
> @@ -664,8 +662,6 @@ void idxd_mask_error_interrupts(struct idxd_device *idxd);
>   void idxd_unmask_error_interrupts(struct idxd_device *idxd);
>   
>   /* device control */
> -int idxd_register_idxd_drv(void);
> -void idxd_unregister_idxd_drv(void);
>   int idxd_device_drv_probe(struct idxd_dev *idxd_dev);
>   void idxd_device_drv_remove(struct idxd_dev *idxd_dev);
>   int drv_enable_wq(struct idxd_wq *wq);
> @@ -710,7 +706,6 @@ int idxd_enqcmds(struct idxd_wq *wq, void __iomem *portal, const void *desc);
>   /* dmaengine */
>   int idxd_register_dma_device(struct idxd_device *idxd);
>   void idxd_unregister_dma_device(struct idxd_device *idxd);
> -void idxd_parse_completion_status(u8 status, enum dmaengine_tx_result *res);
>   void idxd_dma_complete_txd(struct idxd_desc *desc,
>   			   enum idxd_complete_type comp_type, bool free_desc);
>