Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp39703rdb; Mon, 14 Aug 2023 08:56:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHx5UcW8vEzM6SufukoOBD9Wl3walli4hme68BYMBaEbbOG/pNO4FJ1Mxv9DTlbcvCJDP4n X-Received: by 2002:a17:90a:648e:b0:268:220a:7080 with SMTP id h14-20020a17090a648e00b00268220a7080mr16527958pjj.2.1692028561010; Mon, 14 Aug 2023 08:56:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692028560; cv=none; d=google.com; s=arc-20160816; b=Wfyoh6fZLCw1Fqrj0NEarmMjZbRFpiRCiKHDx0ekLeFUfXegnWUdX13nBdNcUvErQs 03B4uTJiwKA0X2DBqA0o89+AugMECEl1+TpTfcOWYwB/kNcMR8Lad9oczGVsMoP0kvUH Rud+emqcHqyPllB9uPj26KQkELXxh/2JIsN7yGBv5cSdAnyXQs2VmjWKORExq5Br+Q2T xM26fuykfZINNS3OhbS0F/jCoTESZhVlYdS/rLuWpCCIixNDL18hH/Ol3rG/x+Xl2MB4 +94nPHyu6SYeP/UaMkSmHmr8xVOkY68HdAk6lq08CyaaEjs+yVpCjAKvKi/wrJDcR6Yf p45A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=xFaWF1VPCbC+uQA97N7ekQh+GbOSUEPbLIXGhunyUxE=; fh=DO7dI+Q5zSMHDen+khW9KGFvdQFNVq2M/aRhcg7ibeU=; b=z7VZz7AQ87/CxyqA5qrgA0pYDiif0P0lsV8WxuEvDQr2zurdLABKB2q0ePUF2sxl67 haBnKvgdC6w+RxpnCZVErQNr1sr1xcj1kXJVGNGWIP+Z1muXO/Yzqo2Y4IrX8BP7UH7V PYND+ee4ZmiqxawnK7k+2hvD6BjRlEoWxP9nQWlDvNE5Z0LcMNTGaH0ezhDsNQZNZiuX hEiBb+k01sm2eEkIsSY9Jp9qbaP5jaHd8nVN1pkKwoTc7b4sW/QgU+RX0IhdJKPRHMH8 psTXHzxF9swXeutlQ06fR8SztDir9vhdGLhjfVzIBHRg3FRDTUKduhNWE/pKSYA6ZTxG qraQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2Uiqqxs2; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=d4H10t5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v19-20020a17090ad59300b0025c16614fa6si10262348pju.145.2023.08.14.08.55.49; Mon, 14 Aug 2023 08:56:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2Uiqqxs2; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=d4H10t5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232340AbjHNOk6 (ORCPT + 99 others); Mon, 14 Aug 2023 10:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232271AbjHNOk0 (ORCPT ); Mon, 14 Aug 2023 10:40:26 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24073F5 for ; Mon, 14 Aug 2023 07:40:26 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1692024024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xFaWF1VPCbC+uQA97N7ekQh+GbOSUEPbLIXGhunyUxE=; b=2Uiqqxs2NFtSG8+8AuibWxhGDZz9qmWnw1So2QlhUnTOF1SGtGIqkNvIzdGqRqxWDrRdfU gUvxa95jWmAFTajnov8lnPKbQE3BzAYGcElMCJi6tGnDMSAfR0GCwdlPFJvNg2if0OqMm/ SJZ6cBAMQplJlybxWIZWHY/vH1LGKb35NcB6Wj16KZlBohntD1yGgcphUONqVmw2jhuxgw ujVOHymW+rUGGnIEv+clLDpWDWJyRskNbfOGzX25Urdi4Qwu2ilz+QLOngsCee+wR/RH6N w7/YKaa9OzKdGvgKeyIJKovTr+TQwNXpeokBPbOrYij8aUY1uEgjbxn/YzkaEQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1692024024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xFaWF1VPCbC+uQA97N7ekQh+GbOSUEPbLIXGhunyUxE=; b=d4H10t5c2uujL9wBcuchKEdKOGIVxLd3PhyoHqnLqSl3OfXyD0DPwd8T6jYfOQGoxJ4Vam JzXhAqFPiaf3cNAw== To: Borislav Petkov Cc: LKML , x86@kernel.org, Ashok Raj , Arjan van de Ven , Nikolay Borisov Subject: Re: [patch V2 12/37] x86/microcode/intel: Simplify and rename generic_load_microcode() In-Reply-To: <20230814131927.GEZNop39tb9LxSjFLK@fat_crate.local> References: <20230812194003.682298127@linutronix.de> <20230812195728.246048244@linutronix.de> <20230814131927.GEZNop39tb9LxSjFLK@fat_crate.local> Date: Mon, 14 Aug 2023 16:40:24 +0200 Message-ID: <87leed3cx3.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14 2023 at 15:19, Borislav Petkov wrote: > On Sat, Aug 12, 2023 at 09:58:55PM +0200, Thomas Gleixner wrote: >> @@ -645,14 +632,12 @@ static enum ucode_state apply_microcode_ >> return ret; >> } >> >> -static enum ucode_state generic_load_microcode(int cpu, struct iov_iter *iter) >> +static enum ucode_state read_ucode_intel(int cpu, struct iov_iter *iter) > > I'd do this ontop: Sure.