Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <422d202b-2e2e-b01f-436b-bdf7c7024960@quicinc.com>
Date:   Mon, 14 Aug 2023 20:07:39 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW
 spec
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
CC:     <mani@kernel.org>, <quic_nguyenb@quicinc.com>,
        <quic_cang@quicinc.com>, <quic_asutoshd@quicinc.com>,
        <avri.altman@wdc.com>, <martin.petersen@oracle.com>,
        <beanhuo@micron.com>, <bvanassche@acm.org>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <agross@kernel.org>, <konrad.dybcio@linaro.org>,
        <jejb@linux.ibm.com>, <linux-arm-msm@vger.kernel.org>,
        <quic_ziqichen@quicinc.com>,
        "Naveen Kumar Goud Arepalli" <quic_narepall@quicinc.com>
References: <20230809151243.17531-1-quic_nitirawa@quicinc.com>
 <yw5mgmk5q6vhwmu5oiqpg5kvafhlojzposoiaiy4j7wynov6sg@fgbx3twcsuwd>
From:   Nitin Rawat <quic_nitirawa@quicinc.com>
In-Reply-To: <yw5mgmk5q6vhwmu5oiqpg5kvafhlojzposoiaiy4j7wynov6sg@fgbx3twcsuwd>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Bjorn,

I've updated the commit message in latest Patchset. Please can you help 
review.

Regards,
Nitin


On 8/10/2023 8:11 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 08:42:43PM +0530, Nitin Rawat wrote:
>> Align clock configuration as per Qualcomm UFS controller
>> hardware specification.
>>
>> This change updates UFS_SYS1CLK_1US, CORE_CLK_1US_CYCLES,
>> PA_VS_CORE_CLK_40NS_CYCLES timer configuration for Qunipro
>> and UTP to align with Qualcomm UFS HW specification.
> 
> "Code is wrong, make code right"
> 
> 
> I find it hard to believe that "the clock configuration is wrong" takes
> 207 lines of code to address.
> 
> Please instead describe the problem you're solving, to ensure that
> current and future readers of this commit message have a chance to
> understand why this change was made.
> 
> The "describing your changes" section in the documentation is good,
> please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> 
> Regards,
> Bjorn