Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2af57964-9c63-b67b-5cfb-0191cee1ef14@intel.com>
Date:   Mon, 14 Aug 2023 08:31:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH -next] dmaengine: idxd: Remove unused declarations
Content-Language: en-US
To:     Yue Haibing <yuehaibing@huawei.com>, <dave.jiang@intel.com>,
        <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230814135952.12892-1-yuehaibing@huawei.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230814135952.12892-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnN0ajVtdU5nS3hWMGlvb3UwWW9rR09BcWNiQlNYeWpMMDc3WEZHeUNIS0tG?=
 =?utf-8?B?aTBQK2hGLzJaalg3ZmQvUVBENUJ0YXZpVUw1dzNlRUY4cHBzVUQwTXA0ZS9G?=
 =?utf-8?B?bjBQL2d2VFhub0F6RkU2OXZQdGt3dE04OU1hUWlmcmplempyK3dJZDNRbU5B?=
 =?utf-8?B?MDR4MU1aaXgxaVI0SUtxcnBEb1AvcVNmVFJrcG5vNUYxMC91WWZHZHJQSDkw?=
 =?utf-8?B?eVc2SXJ5NTNwQzZjU3JRd1pZbDBjWGtPSlZhTE9aZEhlSXoxcC9INlFqL0sx?=
 =?utf-8?B?cTZ4YU4vUTdQVHM0SDdLRmZzN0JQQ3k1V3doeFpTaHpyRHFHRnFzTG02eGgw?=
 =?utf-8?B?ZTJEYW5yS044WXZ3b3NxbXJNZ29FajdJekhSeEE2MTZzT2RZc1FBK2haU2xO?=
 =?utf-8?B?Z3dySFNNeXI0dkhsRlJOOEgzNW1ZdHBKTkN1c1ZpZlpkenB2bis2OXNhOXZ0?=
 =?utf-8?B?LzJOREtlblZNMXl1bHBLck9aalRUeEhiQ1MzT1hwWjUvOURCakJjSUlsN2Nv?=
 =?utf-8?B?S0pTRDIwKzIwNTFweDU5MU5QMW0xVTZmTThUMktWMjNZc21VZGRkUzc3RkE4?=
 =?utf-8?B?N0Z3allZZWJsUWxBWEdPMG5TdXR6MW55bElmaFNmN1dUQjk0cENPcDR5Zksz?=
 =?utf-8?B?cThEaWtHYjlTc2dMTVVLZ0VEQVA2a1dnOTg3dnVORHJJamZoYndlT1RqTFZh?=
 =?utf-8?B?NVo1ak93UTFtK0NFWXF2eTM4ZFlKSGlzekZIOTBpdUM4Z2l1RlZHVGhHZGoz?=
 =?utf-8?B?UWgrL04zRnFMZlZzNCtFVDd5R3NTRXNUcUpOeVp5VmVkM1RVRFFZeGxxdktm?=
 =?utf-8?B?L2pFSVNPVkV0MEZsOUNCOWpFWGlxL1BLTHpiRlV3MWk3UUtYbWFUeXhXTlpz?=
 =?utf-8?B?NS91NGxDM0toc0N6TUVHc04xbFYzNkw1c2diaFZsNzdGbFlFLzRVTUhndGlN?=
 =?utf-8?B?eXV0SEZFUkd5MTRVckhmVlkzN1daVEFJcEVrOHhzc2QzWWs0b1NNWnBRZ2o5?=
 =?utf-8?B?RFdpWjdoWXpSYWlNSXB5cjhYNjBhclNIaUdNYnk0akRUMUxUa1hwOG9EZzdO?=
 =?utf-8?B?SVB1dnFrVHM3MFExemZxUm1pZjRZZisxaVFGV2ZLZnVINTQ4SGZDcnpnVjJv?=
 =?utf-8?B?ZmppN1QwVVBJaXZaOW04L05SOExBQmNSMGhuTFJVTDgwRUM3a0t2S2VZd2sy?=
 =?utf-8?B?NTVaN29rajg5TXZzSFl1Z1Y5Q1dacUxKaU1aeUVGcmFjK2J4SDE3TU5PdGxo?=
 =?utf-8?B?Ukh2d1BjYzRFNmVPRExsNVhPbFVteTI1dnAwYWhVRFFNV1BVK0xNTTFWQm5D?=
 =?utf-8?B?TTNIOHdyd3ZQeU5TUXpacjd2bjVJNXdUYXRNbVR5eVB6S0JjQithWmpNdnhE?=
 =?utf-8?B?ODBZZVRmcVlBdno0N1VGWnJNZURZRnpJY3dJK242TlV2ckxXZDBvbjlsRmNw?=
 =?utf-8?B?cFBnWXlXSVAwTDRMS0hFeWp1UUVtbDBBWXVEVXdUbFJSdXpBbXZQUWpYaS9h?=
 =?utf-8?B?VW85dnFNWTB1ek1scUp1YzNraWxYcHpWeVRwdnhMWXc5Nk1Bc3grQ0F0RDAr?=
 =?utf-8?B?ZzA0aWp1Znl6bXVad1UvSXlFNEdjWmxTM0VzUTJlWmFheC8rMTQ3WVZvY0J1?=
 =?utf-8?B?cEVoWDlYenRMSEZFMi9GZTdGUHZpY2puUGJuR2I4c21CbmNDdnRsYUdlMjdl?=
 =?utf-8?B?cFU5bjlzZk9tZEl3dERkcFhabndUYmZsSjd2b0ZRZnljT0F2c25URzdnMkRV?=
 =?utf-8?B?SDVXUWwvcjlNUXdKbGhVKzlZWTcvVS9NYThjbnF3ZjFOak1HK29xQWNNVnE5?=
 =?utf-8?B?bHVyZ0hwTEZteEVsMTYxY1BkeFpCYWRmNkVMYXdpSms2MG9TM3pGUVNoRERs?=
 =?utf-8?B?bmdMWU9QY0Ewd2IwWW9hUE90d3hoWUQ2RTR2MEtHdFNiWUN6MEpiTVlOSHVW?=
 =?utf-8?B?YmYzanl3dk9YV3lVOHVhanQ1ZHdjelAyaFhhVUJ4U2ViMmpOQndDWlNHclBt?=
 =?utf-8?B?MVBIL0l3eUNoandWMi9lbWkyN05qU09yQlA1YS9yVWlMTWhJa3N4VnZEK2cy?=
 =?utf-8?B?YkRJeUNBa3JsajdZSzR6YnQzZkJ6S08ySUIzUUJ2K0Ezb3lmL0R0MURhaHJ6?=
 =?utf-8?Q?OBOWt3E0BETS9qoanc+dVJ3YA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 964b902a-1b0e-4d17-6670-08db9cdb8e0d
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 15:31:40.0944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UV9COR7lEpHj7AlnRDHp+1Vyp59N3LF0dn99/m4uXkOsMVm6PNfVxQK6qUplhdmU8ODdOnn/IeMgvMCH/k9R+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5803
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Haibing,

On 8/14/23 06:59, Yue Haibing wrote:
> Commit c05257b5600b ("dmanegine: idxd: open code the dsa_drv registration")
> removed idxd_{un}register_driver() but not the declarations.

Is "removed idxd_{un}register_driver() definitions" better?

> Commit 034b3290ba25 ("dmaengine: idxd: create idxd_device sub-driver")
> declared idxd_{un}register_idxd_drv() but never implemented.

s/implemented/implemented it/

> Commit 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine subsystem")
> declared idxd_parse_completion_status() but never implemented.

s/implemented/implemented it/

> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>   drivers/dma/idxd/idxd.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 5428a2e1b1ec..05a83359def9 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -651,8 +651,6 @@ int idxd_register_bus_type(void);
>   void idxd_unregister_bus_type(void);
>   int idxd_register_devices(struct idxd_device *idxd);
>   void idxd_unregister_devices(struct idxd_device *idxd);
> -int idxd_register_driver(void);
> -void idxd_unregister_driver(void);
>   void idxd_wqs_quiesce(struct idxd_device *idxd);
>   bool idxd_queue_int_handle_resubmit(struct idxd_desc *desc);
>   void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count);
> @@ -664,8 +662,6 @@ void idxd_mask_error_interrupts(struct idxd_device *idxd);
>   void idxd_unmask_error_interrupts(struct idxd_device *idxd);
>   
>   /* device control */
> -int idxd_register_idxd_drv(void);
> -void idxd_unregister_idxd_drv(void);
>   int idxd_device_drv_probe(struct idxd_dev *idxd_dev);
>   void idxd_device_drv_remove(struct idxd_dev *idxd_dev);
>   int drv_enable_wq(struct idxd_wq *wq);
> @@ -710,7 +706,6 @@ int idxd_enqcmds(struct idxd_wq *wq, void __iomem *portal, const void *desc);
>   /* dmaengine */
>   int idxd_register_dma_device(struct idxd_device *idxd);
>   void idxd_unregister_dma_device(struct idxd_device *idxd);
> -void idxd_parse_completion_status(u8 status, enum dmaengine_tx_result *res);
>   void idxd_dma_complete_txd(struct idxd_desc *desc,
>   			   enum idxd_complete_type comp_type, bool free_desc);
>   

Other than the minor commit message changes, the code looks good to me.

Thanks.

-Fenghua