Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 18:17:48 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Chengfeng Ye <dg573847474@gmail.com>
Cc:     andi.shyti@kernel.org, rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue
Message-ID: <ZNpTrFj2RoGhg4T9@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Chengfeng Ye <dg573847474@gmail.com>, andi.shyti@kernel.org,
        rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230707084941.28964-1-dg573847474@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="lP44t/20Ow0y+TLX"
Content-Disposition: inline
In-Reply-To: <20230707084941.28964-1-dg573847474@gmail.com>
Precedence: bulk


--lP44t/20Ow0y+TLX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 07, 2023 at 08:49:41AM +0000, Chengfeng Ye wrote:
> iproc_i2c_rd_reg() and iproc_i2c_wr_reg() are called from both
> interrupt context (e.g. bcm_iproc_i2c_isr) and process context
> (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be
> disabled to avoid potential deadlock. To prevent this scenario,
> use spin_lock_irqsave().
>=20
> Fixes: 9a1038728037 ("i2c: iproc: add NIC I2C support")
> Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>

Applied to for-current, thanks!


--lP44t/20Ow0y+TLX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTaU6wACgkQFA3kzBSg
KbaNKRAAtQ5yI2RX3kG1g6Nxx6xQk6u0UG8EvKyZsADukUZxn9ccsUZAuP4vjXOQ
RqqwODwaKhGtngnRhqOkbE2rRoNc6NT7YJqLtnWAznDpW2/HMdbDMsmVbybQ7TiL
uL+LLtT1HqhF24pZXo3XJZmFZI9W5/5ez3oGBgH0RhiSb/7znTX/bqHPpQnoYFHP
tk0NJ6HpiUqHYYjT9ogUBH07CfXgUfW1phYyPZICSGjGdK+wzVlsFLWCEXyVNh8E
hilzIQj3uz1PzuLty1VeJQpFhp+PDvtgZzh402iR/vn1wAELsFki/a5qGl5RQq5u
auNzbT8HGLLlAG8Dfcm9wIdJ64OWnfYKE3WIEptaIYwwDQKBoFyzdr63Au2ShupU
m3V+7he7urtUibjWe+ogWmLOVJEbXMOnCBhfsd5Zt/3uu3dqbnRnT5AWynLRuOKd
RmLuiDx4Ahfx8VRbJ+TpmPjckoVdX7xKUN/crkRpFPORtKRRXHGfshwQE9t4amY0
4QqAu/z44qHoWQ8BUb1OkZyxKcpdwMfIu5IbsjqszHYLG9zQztVuu9wuXDFwghtL
uVU4lQ62CjtzU41BeAKDxmlAZqt+3woZzsZwgXPkZVz5IuAh6st8CGizRno/SA+9
lXX0hZfjldqWMiXuG6grd6O80ZobZHq78CngCDXaBYB4FIHKmhM=
=zNjM
-----END PGP SIGNATURE-----

--lP44t/20Ow0y+TLX--