Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 17:19:01 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Eugen Hristev <eugen.hristev@collabora.com>
Cc:     linux-mediatek@lists.infradead.org, chunfeng.yun@mediatek.com,
        vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        sam.shih@mediatek.com, jieyy.yang@mediatek.com,
        frank-w@public-files.de, linux-arm-kernel@lists.infradead.org,
        linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, chris.obbard@collabora.com,
        kernel@collabora.com
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: mediatek,tphy: allow simple
 nodename pattern
Message-ID: <20230814-isolating-faceless-72835873207e@spud>
References: <20230814093931.9298-1-eugen.hristev@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="g/mf8JY5atzBFUNd"
Content-Disposition: inline
In-Reply-To: <20230814093931.9298-1-eugen.hristev@collabora.com>
Precedence: bulk


--g/mf8JY5atzBFUNd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 14, 2023 at 12:39:30PM +0300, Eugen Hristev wrote:
> The pattern for the nodename only allows t-phy@... , however, for the case
> when the t-phy has no `reg` and only `ranges` (basically when the t-phy
> is just a parent node), dtc will throw this warning:
>=20
> Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but=
 no reg or ranges property
>=20
> For a node like this:
>=20
> 	sata_phy: t-phy@1a243000 {
> 		ranges;
>=20
> 		sata_port: sata-phy@1a243000 {
> 			reg =3D <0 0x1a243000 0 0x0100>;
> 		};
> 	};
>=20
> it is normal that the parent node 't-phy' would be without any address, a=
s in:
>=20
> 	sata_phy: t-phy {
> 		ranges;
>=20
> 		sata_port: sata-phy@1a243000 {
> 			reg =3D <0 0x1a243000 0 0x0100>;
> 		};
> 	};
>=20
> because being just a holder it does not have its own reg.
>=20
> However the binding does not allow such a name for the t-phy, so with this
> patch, making the `@[0-9a-f]+` part optional, such node is possible.
>=20
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>

This seems reasonable to me, perhaps the lads will scream.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> Changes in v2:
> - none
>  Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/D=
ocumentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 230a17f24966..2bb91542e984 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -64,7 +64,7 @@ description: |
> =20
>  properties:
>    $nodename:
> -    pattern: "^t-phy@[0-9a-f]+$"
> +    pattern: "^t-phy(@[0-9a-f]+)?$"
> =20
>    compatible:
>      oneOf:
> --=20
> 2.34.1
>=20

--g/mf8JY5atzBFUNd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNpT9QAKCRB4tDGHoIJi
0jU2AP9qah5UHtzzFaDMKPLx4YhxWLbBsHowrT9XMVj560Z2twD9FGmBUyZvKKW2
UNhseLnLrkSED1LMAEZNSFekdLZpGgk=
=dvtZ
-----END PGP SIGNATURE-----

--g/mf8JY5atzBFUNd--