Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 09:25:06 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-coco@lists.linux.dev>, Borislav Petkov <bp@alien8.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Dionna Glaze <dionnaglaze@google.com>,
        "Brijesh Singh" <brijesh.singh@amd.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] virt: sevguest: Add TSM_REPORTS support for
 SNP_{GET, GET_EXT}_REPORT
Message-ID: <64da55624c6c1_2138e294cf@dwillia2-xfh.jf.intel.com.notmuch>
References: <169199898909.1782217.10899362240465838600.stgit@dwillia2-xfh.jf.intel.com>
 <169199901829.1782217.16990408177897780160.stgit@dwillia2-xfh.jf.intel.com>
 <20230814112144.GF776869@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230814112144.GF776869@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TpHmUAVgPb7vlIZ3j7jO/JavVFbcLNQ4fcmXqj3rOToWbDJIOjnjkTjQlsst?=
 =?us-ascii?Q?Efz2XbaC3X8prxWEs45do0LQ/UPkBDI/qK5/3jpyljm0b75qRdmWsgO8rCh0?=
 =?us-ascii?Q?1k5jlTEJzErpZAm0mwCkW0rxQTh9qEjAyIBQnRf0W4rCZk+nj9yjbkeHD0Kx?=
 =?us-ascii?Q?NwEuVOIDUOO3LdMzFmBLLC0VBwbsr4honvcEv5dYW6uDbokZS1Ob4oey6d5n?=
 =?us-ascii?Q?c1sXeQOzfdNmxxyN6D0L0YayXB8PGpsBDMZEx8NC+UfXpUzPbiadZFNqeFj1?=
 =?us-ascii?Q?esrJeQ6tvkfAOJ9lpczutwiSuLN9I/+uNdJ9+RJ6XP5wKESw543mzqCMmwII?=
 =?us-ascii?Q?fvqtstaS0VXBtdzytuX6PmGn0StqksKC6YM5YNqjyQJlb1RoXZ3xz96HjLad?=
 =?us-ascii?Q?N5No1e3OODjnPTVLxI8VIuWJJ4eQiWiiZqfq3wXfV/BM4Or52U+7wVQ9Y3KB?=
 =?us-ascii?Q?CVj7XB2UbOTSWM3FA7pHdahsA7wD3jzNrue9KK38BRmbx8kizHItq2pWyeKT?=
 =?us-ascii?Q?8UcYA62GWYe7Q1W0KuYL0/Ag9Ia/BR6wYor8aAJHXZ7RsczPEOWpBsH9Ah3g?=
 =?us-ascii?Q?miPa+Z6XfKlptRTLh92tsOAzt33u2/onYYRvsqErKD7hBbxzi7YkRVQsmS7G?=
 =?us-ascii?Q?O/onXIpf/8Kcg5rePVBgkpzcGVMEWnQye0vRJYgDZEJd2twrPmoDoIaPnLnR?=
 =?us-ascii?Q?jfAUSfjWBYMLJU0bgpgG4kEIh4K6rgCStNBaV1ePzqoR8dwasLvchcA0uRMN?=
 =?us-ascii?Q?mzPDOb3FGJxfBQft8PuQHji3sm64XTGIEfQcFYVwaL8y2UM4ZzsedmRuJmQk?=
 =?us-ascii?Q?m1q+dltfrOga552C3W01OnWCneJP6oh6HNm/4/+gYBBBmdU5i8c8kzJYk42q?=
 =?us-ascii?Q?3iK/NdukK1BA16ixbcB0fFC7gcjw48r5D36UjPiSyYzYbTiWNaAKXs2TPKFf?=
 =?us-ascii?Q?4I03jX0OUJfJYukVtXJkdvmZgEsSQONi3xRyqx/Oxq6Soq9tF/9wzuqY1fra?=
 =?us-ascii?Q?5wYeUiBM3HPxXVmTnwzwV1GD1BcritqQZ1EYYEOOdjbZYyW1wNvjTSbFp2d6?=
 =?us-ascii?Q?7SFmSfrX38HzjEnSQOhQpvgnuJ9XGW3RtMKYTyQibHIcXmHrIiy8UE63INVs?=
 =?us-ascii?Q?vYrgBlqFdQewy9BdOHpFE5Y52qjizqRo0t+3pcoteMyetnLhVCVpD/FNjhZf?=
 =?us-ascii?Q?9OaYMP0N36QoFffL9F6l41PwKN4LCdKbIQuPEVbyB7p1ptzt/bRZECUz8vwV?=
 =?us-ascii?Q?QlbWIAxNXtvR6t9xCrROW69yFeFj/AvzrLrKzNtRkgNqYDAU5Zak1f6PmSqA?=
 =?us-ascii?Q?N/sumiBgYZASUjiyt7pHLF/l+d8h2ZPpQZ9cddzMfexMyzGqQNDIq1xtxdLl?=
 =?us-ascii?Q?nmxKlK+hxjc8idfNXb9tQQlfRRBEXdX2hbVXZ1T5MwXJM/xoHXZA8PGhdM7C?=
 =?us-ascii?Q?NhTaOtBwNAWe8yA8qPfZ6iLa5VdSMhCu74zLFK1Ix49plhooAyMn+YAoCWrS?=
 =?us-ascii?Q?MdglFCnAgF9NbaIft6aRPfIYghXv2cCU/5ThLILHTL0LGlkfl3rBl3J2XhQh?=
 =?us-ascii?Q?BDsT4ryn7kru7Itq28R3nOYFiYHnfisr39NhkpQg8rKeiJi8r/ragJ2UvYUf?=
 =?us-ascii?Q?yQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0583bf-4404-4457-c3a3-08db9ce306f5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 16:25:09.2910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0eVjMMhHU6Id9nqwUGbLoEZkwqClX0xAwmA94L9ZFgazgbdd2axFOukrbPId4Hcc2OHhrWHy2YJaLMFAKtwy5xYfZxuaVOSu16OancX8DqI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6233
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Peter Zijlstra wrote:
> On Mon, Aug 14, 2023 at 12:43:38AM -0700, Dan Williams wrote:
> > +static u8 *sev_report_new(struct device *dev, const struct tsm_desc *desc,
> 
> > +			  size_t *outblob_len)
> > +{
> 
> > +
> > +	u8 *buf __free(kvfree) = kvzalloc(size, GFP_KERNEL);
> > +
> 
> > +
> > +	*outblob_len = size;
> > +	no_free_ptr(buf);
> > +	return buf;
> 
> This seems broken, no_free_ptr(x) is basically xchg(X, NULL) (except no
> atomics). So the above would end up being:
> 
> 	return NULL;
> 
> What you want to write is somehting like:
> 
> 	return no_free_ptr(buf);
> 
> or, a convenient shorthand:
> 
> 	return_ptr(buf);
> 

Oh, I indeed did not realize that no_free_ptr() had side effects beyond
canceling the free when the variable goes out of scope. Will switch to
return_ptr().