Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <2a9592bf3340f34bf588eec984b23ee219f3985e.1692013451.git.heinzm@redhat.com>
In-Reply-To: <2a9592bf3340f34bf588eec984b23ee219f3985e.1692013451.git.heinzm@redhat.com>
From:   Song Liu <song@kernel.org>
Date:   Tue, 15 Aug 2023 00:25:52 +0800
Message-ID: <CAPhsuW7VXegx5+q0L5UHcRMRAyyJHBM_6ag4Y-o4fSiK1yDjCQ@mail.gmail.com>
Subject: Re: [PATCH v2] md raid1: allow writebehind to work on any leg device
 set WriteMostly
To:     heinzm@redhat.com
Cc:     linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        xni@redhat.com, ncroxon@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 14, 2023 at 8:04=E2=80=AFPM <heinzm@redhat.com> wrote:
>
> From: Heinz Mauelshagen <heinzm@redhat.com>
>
> This is version 2 replacing my previous patch series as requested by Song=
 Liu.

For future patches, you can move the line above to ...

>
> As the WriteMostly flag can be set on any component device of a RAID1
> array, remove the constraint that it only works if set on the first one.
>
>
> Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
> Tested-by: Xiao Ni <xni@redhat.com>
> ---

... here, below an extra "---" so that git-am will remove it automatically.

Other than this, applied to md-next.

Thanks,
Song

> ---
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index dd25832eb045..913cd46b786b 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1519,7 +1519,7 @@ static void raid1_write_request(struct mddev *mddev=
, struct bio *bio,
>                          * allocate memory, or a reader on WriteMostly
>                          * is waiting for behind writes to flush */
>                         if (bitmap &&
> -                           test_bit(WriteMostly, &rdev->flags) &&
> +                           write_behind &&
>                             (atomic_read(&bitmap->behind_writes)
>                              < mddev->bitmap_info.max_write_behind) &&
>                             !waitqueue_active(&bitmap->behind_wait)) {
> --
> 2.41.0
>