Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 10:12:11 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <linux-coco@lists.linux.dev>
CC:     Brijesh Singh <brijesh.singh@amd.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Peter Gonda <pgonda@google.com>,
        Borislav Petkov <bp@alien8.de>,
        Dionna Amalie Glaze <dionnaglaze@google.com>,
        Samuel Ortiz <sameo@rivosinc.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] tsm: Attestation Report ABI
Message-ID: <64da606b171cc_2138e29484@dwillia2-xfh.jf.intel.com.notmuch>
References: <169199898909.1782217.10899362240465838600.stgit@dwillia2-xfh.jf.intel.com>
 <57f3a05e-8fcd-4656-beea-56bb8365ae64@linux.microsoft.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <57f3a05e-8fcd-4656-beea-56bb8365ae64@linux.microsoft.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mMfBS0ecTRwGYywMXFHZMYr5sw95IX9TE3EKopp7td1Cke9JJvOuNIAaKd3p?=
 =?us-ascii?Q?yj2cDPvtb+dtaYFEGhnOvSbG5hJ5blVwzPWfx/P0NktoBy88T8WkoQ1yTX8E?=
 =?us-ascii?Q?mLD2+TBUSqBz7drEx9ZavSn9coEdzXFt8rkf3jRx3SAipxKKMkBkCy0NyHm0?=
 =?us-ascii?Q?5TX1t4+vteZLz9hCbVGKHraIoV7nsTQ9Z7qK+uVw/JEv7zVv4OON4drdGsc1?=
 =?us-ascii?Q?DiXxXLu1sFDfQKWmMQO8tkerj2fMUhp2byvvQ0dflZuJc5nHu64VQdgKJNGG?=
 =?us-ascii?Q?NtIP8qD/4B3JSjuxZOV52reH+kribWNUGQ0XBTMgDuFqwyLHgQJ76HUJgyU2?=
 =?us-ascii?Q?3uwhwi46twgAIC3xGgWUP0C+g1zTH2dP/AbAWrpFZQFzr7+3VQ/QYvb5/cll?=
 =?us-ascii?Q?ec0j2+Ow5WvGLVg6TTdvseqnwy1u/6DEZDzKg9iRjr0VIBxYoJbxwA5KDap+?=
 =?us-ascii?Q?yQZmnorU5L/nsb9mpgcH7Fb6KYUeCRdhh6+ErxULhc9HiZboqejTQJlW9pnw?=
 =?us-ascii?Q?p16qhnbg+euuMrF1N1EJwRCikJJD6H8TyZAs/4vDfL5Z8V6qd7119ME3LCIB?=
 =?us-ascii?Q?Cb4S9Ua1OE3v+bcClF44nVB3ZhDsMJh7jO52fcOFIRivpd7Dj9CWX5zJ5e4H?=
 =?us-ascii?Q?h9iDBfQt5PMQGEUYjT5LT4E8HGmvjCm99Ha6OwAg+44Amg6XgSsn/zUwvEUc?=
 =?us-ascii?Q?thXMYfvNBWjmObTozeHe7X+qIImf3/xwf9ODBD50ysxWO2thHSdjDH624LIW?=
 =?us-ascii?Q?tequIWMSHjVhNut9JMr4iSZNXjrCJcgfKTC2ROcR2TqVyK0XI5/U125s7Von?=
 =?us-ascii?Q?DMaV+xxdNNjJ0lmr8WLeWCooyIHWIO3DKlPcIgDy7stQTqJKGHGkWAB5e98Z?=
 =?us-ascii?Q?zNdBQSEdjt5JO55maBX/06UBk88bSBhMG8y8cy6PIkaVUqH2QEijFkhn9oZY?=
 =?us-ascii?Q?Yu2yn/tz1CdfAKx3bhMPWTADzs8y7ko4cruLTuKn6mscikDGCjSusvu6fvWK?=
 =?us-ascii?Q?DoziSmKyZHqa5vEkvUkPkJwJR2r2kZtfco1W67YgHWqicD3CRf5uqAfZMQXZ?=
 =?us-ascii?Q?pdaBAmmKpMM+Bm5b1Rr+v9mbL3NNqBFj3y3EMFR/F/yp64meeK6cSLzzhWGg?=
 =?us-ascii?Q?v02HEBgNvLTnUkHlroXm5B2D66XQQ9Ali/IhjdoPaYVbUcamv9JfSm7LlNek?=
 =?us-ascii?Q?Pli62pqcALwlEDI4mqAf8kAfVylHo7yEIZQFRJE6XfwQ9ADFsP3FuaEXF1UY?=
 =?us-ascii?Q?jBSRA7VNF/rm7co2XgOO2m4B697QRAKt1V46jvmxtTmCZIqyUelMk25iGL9e?=
 =?us-ascii?Q?cn+rxwI6AX+sEQF2UpQ/BZ7194tH+5ZoLyr0YMTLy2hQLJYh0wVlvljlvGMI?=
 =?us-ascii?Q?oR9w0hA16LiAZQx1wpej7WTET0ivF7jSl6WrRnPi2qRRnPCaXqA4Vpr8kgaq?=
 =?us-ascii?Q?FHw6f260OhyoKFi5/EG2rSEUOhZS/PYh+lMMVpYcgpdywIsGYmZ98leWXBfr?=
 =?us-ascii?Q?c6B3+RTx/TJ0/4BSSI6OrZyJH03g0r4H1Su4dBiXMXbpdM+A0Tv3qpz7tlK+?=
 =?us-ascii?Q?u3npmyE2qAF7qd4XTW+DrbprjOuwtOpM+Viy2w/5adirEbyvKm8bNue378uK?=
 =?us-ascii?Q?lQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d7fff46a-05d8-4cce-aa1c-08db9ce99af8
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 17:12:14.8377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X7N40hk2tG+Xr0NogI1eU8W74cjugqLKOZZKqb3Nmt/ZxC+eQVhwaE6abwCcps3Dp0sm+tgGUvUY34wGSFwgBss+WZoaoktder4adTNOb2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4733
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jeremi Piotrowski wrote:
> On 8/14/2023 9:43 AM, Dan Williams wrote:
> > Changes since v1:
> > - Switch from Keyring to sysfs (James)
> > 
> > An attestation report is signed evidence of how a Trusted Virtual
> > Machine (TVM) was launched and its current state. A verifying party uses
> > the report to make judgements of the confidentiality and integrity of
> > that execution environment. Upon successful attestation the verifying
> > party may, for example, proceed to deploy secrets to the TVM to carry
> > out a workload. Multiple confidential computing platforms share this
> > similar flow.
> > 
> > The approach of adding adding new char devs and new ioctls, for what
> > amounts to the same logical functionality with minor formatting
> > differences across vendors [1], is untenable. Common concepts and the
> > community benefit from common infrastructure.
> > 
> > Use sysfs for this facility for maintainability compared to ioctl(). The
> > expectation is that this interface is a boot time, configure once, get
> > report, and done flow. I.e. not something that receives ongoing
> > transactions at runtime. However, runtime retrieval is not precluded and
> > a mechanism to detect potential configuration conflicts from
> > multiple-threads using this interface is included.
> > 
> 
> I wanted to speak up to say that this does not align with the needs we have
> in the Confidential Containers project. We want to be able to perform attestation
> not just once during boot but during the lifecycle of the confidential VM. We
> may need to fetch a fresh attestation report from a trusted agent but also from
> arbitrary applications running in containers.
> 
> The trusted agent might need attestation when launching a new container from an
> encrypted container image or when a new secret is being added to the VM - both
> of these events may happen at any time (also when containerized applications
> are already executing).
> 
> Container applications have their own uses for attestation, such as when they need
> to fetch keys required to decrypt payloads. We also have things like performing
> attestation when establishing a TLS or ssh connection to provide an attested e2e
> encrypted communication channel.

...and you expect that the boot time attestation becomes invalidated
later at run time such that ongoing round trips to the TSM are needed? I
am looking at "Table 21. ATTESTATION_REPORT Structure" for example and
not seeing data there that changes from one request to the next. Runtime
validation likely looks more like the vTPM use case with PCRs. That will
leverage the existing / common TPM ABI.

> I don't think sysfs is suitable for such concurrent transactions. Also if you think
> about exposing the sysfs interface to an application in a container, this requires
> bind mounting rw part of the sysfs tree into the mount namespace - not ideal.

sysfs is not suitable for concurrent transactions. The container would
need to have an alternate path to request that the singleton owner of
the interface generate new reports, or use the boot time attestation to
derive per container communication sessions to the attestation agent.