Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Aug 2023 19:27:04 +0100
From:   Mark Brown <broonie@kernel.org>
To:     John Watts <contact@jookia.org>
Cc:     alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, patches@opensource.cirrus.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property
Message-ID: <a7db4653-cb12-4f90-891c-5cf7270598bd@sirena.org.uk>
References: <20230810224930.3216717-1-contact@jookia.org>
 <20230810224930.3216717-4-contact@jookia.org>
 <ZNY+x/R8/T5ysPhy@finisterre.sirena.org.uk>
 <ZNZFB2-kBrpnMSn1@titan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/aJxk8MMdf/9RpDh"
Content-Disposition: inline
In-Reply-To: <ZNZFB2-kBrpnMSn1@titan>
Precedence: bulk


--/aJxk8MMdf/9RpDh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Aug 12, 2023 at 12:26:15AM +1000, John Watts wrote:
> On Fri, Aug 11, 2023 at 02:59:35PM +0100, Mark Brown wrote:
> > On Fri, Aug 11, 2023 at 08:49:30AM +1000, John Watts wrote:

> > > + - max-rate    : max supported audio rate configured by FSAMPEN pin, defaults to 48000

> > This seems like a cumbersome and error prone way to configure this - why
> > not just have the binding specify the state of the pin?  That's just a
> > boolean high/low whereas this requires getting the rate right and then
> > having the driver validate it.

> Hi there, the pin is tristate, Z, 0 and 1. How would that be represented?

You'd have to define an enum for that but it does still feel like it
might be easier to work with since it's more direct.

--/aJxk8MMdf/9RpDh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTacfcACgkQJNaLcl1U
h9BXKwgAgSwKyeLPqTWs0T7jIJ1qzjNVtHtx9g/zqFqy1CMWB3obyrIoAkqQ1sZ2
U4O+KbXHmiwtcMnIiw/pgob0Of909XoX+sod5z8Vo/gDwF9rpKcxf30q07vr38Zg
4X0Y+BMPgQ8t6pXYw/7f6jzqdWr9NS/RiiTeBnhTg0rCJ69/0SOKhetiEBbYuOH/
VHx/VGQPuwkgczW6p72rzZp/92OUqbWufopBLgRZjCzvEl96EsoYImaeYqfKc+9r
Ww34k3led/5NINa7WcDiWjG2DJLsUZA8Jc9Wu3fL/hZGZrhvFx5OZmfCT3/V6DQd
Grc4VfsPpVjKok9G6ZXUHvaW7lFuhg==
=Us4P
-----END PGP SIGNATURE-----

--/aJxk8MMdf/9RpDh--