Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757804AbXKCJll (ORCPT ); Sat, 3 Nov 2007 05:41:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753748AbXKCJlc (ORCPT ); Sat, 3 Nov 2007 05:41:32 -0400 Received: from mtagate3.uk.ibm.com ([195.212.29.136]:26522 "EHLO mtagate3.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535AbXKCJlb (ORCPT ); Sat, 3 Nov 2007 05:41:31 -0400 Date: Sat, 3 Nov 2007 10:40:58 +0100 From: Heiko Carstens To: Swen Schillig Cc: James Bottomley , Christof Schmitt , linux-scsi@vger.kernel.org, Linux on 390 Port , linux-kernel Subject: Re: [PATCH] zfcp: add some internal zfcp adapter statistics Message-ID: <20071103094058.GA25134@osiris.boeblingen.de.ibm.com> References: <200710311133.52090.swen@vnet.ibm.com> <20071103091722.GA7807@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071103091722.GA7807@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 15 > > + if (!(adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA)) { > > + ZFCP_LOG_NORMAL("error: Enhanced measurement feature not " > > + "supported"); > > + return -EOPNOTSUPP; > > + } Btw. any user can flood the console with these messages if the adapter doesn't support the feature. That can be considered a denial of service attack. Please just return -EOPNOTSUPP and don't print anything on the console. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/