Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a00b0138-19e4-dfb9-ecc4-3b4e7ae562dc@acm.org>
Date:   Mon, 14 Aug 2023 14:24:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in
 hba_init
Content-Language: en-US
To:     Brian Masney <bmasney@redhat.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        alim.akhtar@samsung.com, avri.altman@wdc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hugo@hugovil.com, quic_nguyenb@quicinc.com
References: <20230814184352.200531-1-bmasney@redhat.com>
 <20230814184352.200531-2-bmasney@redhat.com>
 <f01040be-dfa5-fe60-fba5-410fccc1d50e@acm.org> <ZNqaN5+Ft5PAE43x@brian-x1>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <ZNqaN5+Ft5PAE43x@brian-x1>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/14/23 14:18, Brian Masney wrote:
> On Mon, Aug 14, 2023 at 12:31:31PM -0700, Bart Van Assche wrote:
>> On 8/14/23 11:43, Brian Masney wrote:
>>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
>>> index 129446775796..409d176542e1 100644
>>> --- a/drivers/ufs/core/ufshcd.c
>>> +++ b/drivers/ufs/core/ufshcd.c
>>> @@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
>>>    	err = ufshcd_vops_init(hba);
>>>    	if (err)
>>> -		dev_err(hba->dev, "%s: variant %s init failed err %d\n",
>>> -			__func__, ufshcd_get_var_name(hba), err);
>>> +		dev_err_probe(hba->dev, err,
>>> +			      "%s: variant %s init failed err %d\n",
>>> +			      __func__, ufshcd_get_var_name(hba), err);
>>>    out:
>>>    	return err;
>>>    }
>>
>> This opportunity could have been used to improve the grammar of the reported
>> error message. Anyway:
> 
> That's what I originally did in v1, however I was asked to split out the
> cleanup into a different patch. Split out, I think the cleanup on it's
> own isn't worth it's own patch, so that's why I dropped it.
> 
> https://lore.kernel.org/lkml/20230808142650.1713432-2-bmasney@redhat.com/

Changing an error message and introducing dev_err_probe() at the same time is
fine. I don't think that is what the reviewer complained about. The complaint
probably was about renaming 'err' into 'ret' and about changing 'goto out'
into 'return 0'?

Thanks,

Bart.