Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Aug 2023 09:43:56 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Kemeng Shi <shikemeng@huaweicloud.com>, pasha.tatashin@soleen.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext
Message-ID: <20230815064356.GP2607694@kernel.org>
References: <20230718145812.1991717-1-shikemeng@huaweicloud.com>
 <20230719094421.GI1901145@kernel.org>
 <aa2134aa-3767-b9fe-1504-d6945e8c2f7b@huaweicloud.com>
 <20230720053736.GM1901145@kernel.org>
 <20230811143929.79ee3231cbcdfbe43852a4bf@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230811143929.79ee3231cbcdfbe43852a4bf@linux-foundation.org>
Precedence: bulk

On Fri, Aug 11, 2023 at 02:39:29PM -0700, Andrew Morton wrote:
> On Thu, 20 Jul 2023 08:37:36 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> 
> > Hi,
> > 
> > On Thu, Jul 20, 2023 at 10:38:39AM +0800, Kemeng Shi wrote:
> > > 
> > > on 7/19/2023 5:44 PM, Mike Rapoport wrote:
> > > > On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote:
> > > >> Current client get data from page_ext by adding offset which is auto
> > > >> generated in page_ext core and expose the data layout design insdie
> > > >> page_ext core. This series adds a page_ext_data to hide offset from
> > > >> client. Thanks!
> > > > 
> > > > Implementers of page_ext_operations are anyway intimately related to
> > > > page_ext, so I'm not convinced this has any value.
> > > >  
> > > Hi Mike, thanks for reply. I thinks page_ext_operations can be futher splited
> > > into public part which used by client to simply register and private part which
> > > only page_ext core cares and should not be accessed by client directly
> > > to reduce decoupling.
> > 
> > It would be easier to justify changes in this series if they were a part of
> > the refactoring you describe here.
> > 
> > > This series makes offset to be private which client
> > > doesn't really care to hide data layout inside page_ext core from client.
> > > There are some concrete gains I can list for now:
> > > 1. Future client cound call page_ext_data directly instead of define a
> > > new function like get_page_owner to get it's data.
> > > 2. No change to client if layout of page_ext data change.
> > 
> > These should be a part of the changelog.
> > 
> 
> I added this to the [0/N]:
> 
> : Benefits include:
> : 
> : 1. Future clients can call page_ext_data directly instead of defining
> :    a new function like get_page_owner to get the data.
> : 
> : 2. There is no change to clients if the layout of page_ext data changes.
> 
> Mike, what is your position on this patchset now?

I'm fine with it, so if it's not too much hassle to add it now

Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>

 
> Thanks.

-- 
Sincerely yours,
Mike.