Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Aug 2023 08:04:54 +0200
From:   Florian Westphal <fw@strlen.de>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Dong Chenchen <dongchenchen2@huawei.com>,
        steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, fw@strlen.de, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, timo.teras@iki.fi,
        yuehaibing@huawei.com, weiyongjun1@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch net, v2] net: xfrm: skip policies marked as dead while
 reinserting policies
Message-ID: <20230815060454.GA2833@breakpoint.cc>
References: <20230814140013.712001-1-dongchenchen2@huawei.com>
 <20230815060026.GE22185@unreal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230815060026.GE22185@unreal>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Leon Romanovsky <leon@kernel.org> wrote:
> >  		dir = xfrm_policy_id2dir(policy->index);
> > -		if (policy->walk.dead || dir >= XFRM_POLICY_MAX)
> > +		if (dir >= XFRM_POLICY_MAX)
> 
> This change is unnecessary, previous code was perfectly fine.

Are you sure? AFAICS walker struct has no 'index' member.