Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "'minyard@acm.org'" <minyard@acm.org>,
        Justin Stitt <justinstitt@google.com>
CC:     Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>,
        "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        Arnd Bergmann <arnd@arndb.de>,
        kernel test robot <lkp@intel.com>
Subject: RE: [PATCH] ipmi_si: fix -Wvoid-pointer-to-enum-cast warning
Thread-Topic: [PATCH] ipmi_si: fix -Wvoid-pointer-to-enum-cast warning
Thread-Index: AQHZzJJNhRgyMCyjXUCyrlg7Yy+IN6/rOtTw
Date:   Tue, 15 Aug 2023 11:19:50 +0000
Message-ID: <85c5e4b69dbb4ff699f380b373f6440f@AcuMS.aculab.com>
References: <20230809-cbl-1902-v1-1-92def12d1dea@google.com>
 <ZNaZrHEs5FP7Lf8A@mail.minyard.net>
In-Reply-To: <ZNaZrHEs5FP7Lf8A@mail.minyard.net>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Corey Minyard
> Sent: 11 August 2023 21:27
...
> >  	memset(&io, 0, sizeof(io));
> > -	io.si_type	= (enum si_type) match->data;
> > +	io.si_type	= (unsigned long) match->data;
> 
> Wouldn't you want to use intptr_t or uintptr_t?

The kernel tends to use 'long' for the same reason
it doesn't use uint8_t.

Although I'm sure the correct/better fix is to either add variants
of the match/lookup functions that return (say) unsigned long
or change all the drivers to allocate a structure that contains
the required value.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)