Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp663965rdb; Tue, 15 Aug 2023 08:20:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6zhGs3Pmd0ZpNVKZd38v6zCZTjI0wb+OCeBRYW+vUctsQ5iR1CZhwR1QTK76ji+b4eENg X-Received: by 2002:ac2:484a:0:b0:4f8:7960:f72 with SMTP id 10-20020ac2484a000000b004f879600f72mr8377503lfy.44.1692112845757; Tue, 15 Aug 2023 08:20:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692112845; cv=none; d=google.com; s=arc-20160816; b=hhX3zZfBlD4BcHCCBfpWP/ERhlhmpRBtdNsy0ghsWMH+Q0bYaHk+YZG7d6KH50Kh5X l5lhIXXFahPfsoQsXdLnoJFANGXLwadUXvsPEC4EY2d66Z71mc1x3GnF2/rP4CY6GtHP /KeiIhMZ/w4OQ8k3zx/JIvxvMWZsxFJx0nitxiwQBggDujw9pBMFjbchW5gBXntRXOHq DLSLvW6sE1nNoWDvV7nrwkmZ9Hs4ydKw36SRTZAUUnkatyeguvZemYgGDh3CYqhsCE1D bIwpeJai1+klb/o8FEhD9bDcdayMIFn+eDTzlYwDyeCnqhIrsMQHTO2e+HIk4n2zWCE4 CdsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=9PWPemOcv6PhOchLL6u+Q4+Fztxsz47uRgROVp8OcGg=; fh=Omnty01DBpbBuErjOh7INKxmVZFBWGBL5wBDOZS1qJo=; b=mI5KaMPyqNBlxN4kMY82avedCZDuaXLEG3Or0x9UDmkTlcVrcIGnN4HGhHm0/R10cT dWyoEgxbcopHPD/8u5v08eeSvQORokGU8Vl+d7QotDFSmXg8TNbAGW0irZATrItT5anl l9YPWivJcd1AAMaI/QN0VnageqXftFnZVxMneeGFcovRzq/mlyZ9Wv1mcpcsTuIyOpDP usDxFQDXzypUe+TmUa16/lZrSM3uDBNEoOKe2yUe7GQV5PNFT/B2kvMMomQM48YeHrYP 2rtf8k32d9vMSt05hM8C5XUitfX+XksVqYrrnnWdNSfPyUakQU9xSmheyMmNpIptWG8t rkJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Gzk1/BLq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r21-20020aa7d155000000b00523af968258si8677739edo.567.2023.08.15.08.20.08; Tue, 15 Aug 2023 08:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Gzk1/BLq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbjHOCTC (ORCPT + 99 others); Mon, 14 Aug 2023 22:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbjHOCTB (ORCPT ); Mon, 14 Aug 2023 22:19:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9C8A2; Mon, 14 Aug 2023 19:19:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D93E61E31; Tue, 15 Aug 2023 02:19:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE95EC433C8; Tue, 15 Aug 2023 02:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692065939; bh=WlbM/heytKtCeqZZp8rGyTYqC/JyepjBu46WF/ixl1E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Gzk1/BLqzLvrLF8bTNxmpu6nd3or812jH4ByTp0KfVgkmEY6Jmznc4ktLBlyYo91t LUsbV55OoIGkMHwQL2Urdb68rCgd68q1rNrWT7blYbMWNuSqacDQ1SzUvQSn6ciVry o6X3+PGX9T3ypHZORax+KWzdmFTjPyTSMCH7iXo9JAWVwOtUnyuVhSOImnoN44jxOQ lVzTtBIFtg0x5k5VOGoVyTKH/yILQdA+XT87PmqrdSRytSP4X4g/0+PhEqL/0uxSiU Zp+0MqCB0qevEpZSes7Q9+zUd+s+owMbWI03ujxkyCKf8sLK1+mGZ8w92dznO45EqN kQpao+bF97J7A== Message-ID: <1227c807-c452-09a9-5a10-4471f2e77053@kernel.org> Date: Tue, 15 Aug 2023 11:18:57 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused code Content-Language: en-US To: Wenchao Hao , John Garry , Jason Yan , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: louhongxiang@huawei.com References: <20230729102451.2452826-1-haowenchao2@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230729102451.2452826-1-haowenchao2@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/23 19:24, Wenchao Hao wrote: > sas_queue_reset is always called with param "wait" set to 0, so > remove it from this function's param list. And remove unused > function sas_wait_eh. > > Signed-off-by: Wenchao Hao Looks OK. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research