Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp674379rdb; Tue, 15 Aug 2023 08:38:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEl4EttZJb1NrUct19NPOotpUb04231ZgpU3YKTMrvJ2qwYU8AXKQlfhCVneNIIVLajKWP3 X-Received: by 2002:a05:6512:318a:b0:4ff:7f57:facd with SMTP id i10-20020a056512318a00b004ff7f57facdmr2885738lfe.54.1692113882724; Tue, 15 Aug 2023 08:38:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692113882; cv=none; d=google.com; s=arc-20160816; b=bBWp7mWJOWreEa+ak55NfrUI2SGwqjedY9RbwgYlVUOKoXLNTKgc9vCS0IEKYdmPmB qvm8YoDnqzkxHn/V6wl4xM7JO2ptYG9luluehXoakfknQwfZhmvwS3yVWX/icY60t9pu AfoZLcYRWmEGRBRe5gMNLIZHObIs6iz1DF9lJiJSe4MQ+CI2AiSQxr97RdC6C1sDDR27 w3u6UucmhjyPlppvVEnqq/o4PWdgr8eBIMJRaBD2imKz0VSyFqTSJdYEjgTG4a2+kUOS QElGaP6dZp+GoRY4K01B+rgKGMyZMeZtiooYN1elwwFOd3ns93oIj00deLtGpVSzkWEz q+ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=152my1ea/LxcKC/dC6yWoEHx8IKYjASbqbZvtKo47po=; fh=ekUdUoLNvKgYOSaPflbbhwDH4bjvBx27G4Y/D2srzJo=; b=jIIAEpQ3AQfbYJGJWjE60q1rTOzfTzyHk3mc5wl2+r3RNYHTHi5u9G897SN5ssyO9+ h992fbDLbOR9AaGvPbl1siYzmVhiH+LTITGHm5SomTIvvbtN2zBx6Vxqb5cnPyT9WHzv ZwlIpmTIF6vJzWjdZ/AG3dwKcrhKPrmBx9C/u8tp2QhXGNTZOCqNkvijf4NDg+vP0Z1f QCAlhRVaEF10MpcrozZZ3fVpMo5kfvpYK7Uh7K1QKhrsHK4M5+J41Y8NG32xiB3d0xqN bKMkn46lZ74Y3H4ArwLIQ4sUVUy3XuguFdOz9HfbP0TxropOm7VV/wem1auB2PjZS2Wq lhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pk2WjsSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v18-20020aa7d9d2000000b005222c4ef218si9509426eds.298.2023.08.15.08.37.37; Tue, 15 Aug 2023 08:38:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pk2WjsSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235328AbjHOHHW (ORCPT + 99 others); Tue, 15 Aug 2023 03:07:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235272AbjHOHHJ (ORCPT ); Tue, 15 Aug 2023 03:07:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A6510D2 for ; Tue, 15 Aug 2023 00:07:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B2CD635AB for ; Tue, 15 Aug 2023 07:07:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F48C433C8; Tue, 15 Aug 2023 07:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692083227; bh=L0E+Jf8ds4KSMC1jMXWy3ZSWVnQ4s+30hFJBjhe745U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pk2WjsSxvBWFYDb4QNIMQD7A/gnUhkxy1awInwPyC0VZ1WPNqKU2MGZDFJChSlfIX 2l0i0dJIRdYQMmzooAmw0BiyUgfsBtAmisRwoGPwGuXLPlxmbuqKxpWK1IZUYEan0Q /FA/FOrBWZCMDEN0MfuL+MloZhO/Movp/IVj8u9HgYVJrijuWcMNqFNsOnByrww9W3 8AzenrOpI7o+/hpO2KMTzLa7NjAAOvnHkCJCwACJSEPt9z8t/mt5Nm2v7JmcZ8c0DL bCoR+0ivt/mNDSQhKOdp6VXNOh3QN7uYPWxAd6bysh5ELcwKhYMg5V2AsoCfyKF6K9 pHiKL86P4wU5w== Date: Tue, 15 Aug 2023 10:07:02 +0300 From: Leon Romanovsky To: Artem Chernyshev Cc: Michael Chan , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] broadcom: b44: Use b44_writephy() return value Message-ID: <20230815070702.GH22185@unreal> References: <20230814210030.332859-1-artem.chernyshev@red-soft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814210030.332859-1-artem.chernyshev@red-soft.ru> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 15, 2023 at 12:00:30AM +0300, Artem Chernyshev wrote: > Return result of b44_writephy() instead of zero to > deal with possible error. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Artem Chernyshev > --- > drivers/net/ethernet/broadcom/b44.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky