Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'David Howells' <dhowells@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Christian Brauner <christian@brauner.io>,
        Matthew Wilcox <willy@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
CC:     "jlayton@kernel.org" <jlayton@kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs
Thread-Topic: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs
Thread-Index: AQHZzGHVnVxrFjw7PE2nk6LHTBa8tq/rOLUQ
Date:   Tue, 15 Aug 2023 11:12:57 +0000
Message-ID: <aceea2408bf049aebb1f1f893281795c@AcuMS.aculab.com>
References: <3710261.1691764329@warthog.procyon.org.uk>
In-Reply-To: <3710261.1691764329@warthog.procyon.org.uk>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: David Howells
> Sent: 11 August 2023 15:32
> 
> Convert the iov_iter iteration macros to inline functions to make the code
> easier to follow.  Ideally, the optimiser would produce much the same code
> in both cases, but the revised code ends up a bit bigger.
...

Actually quite typical because inlining happens much later on.
I suspect that the #define benefits from the compile front-end
optimising constants.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)