Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Aug 2023 09:48:38 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Sibi Sankar <quic_sibis@quicinc.com>
Cc:     cristian.marussi@arm.com, lukasz.luba@arm.com,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, quic_rjendra@quicinc.com,
        srinivas.kandagatla@linaro.org,
        Chandra Sekhar Lingutla <quic_lingutla@quicinc.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support
Message-ID: <20230815084838.46wqgiggnxc6rfpe@bogus>
References: <20230811204818.30928-1-quic_sibis@quicinc.com>
 <20230814092503.xdzafmqu5h3shrlz@bogus>
 <0cfd73bb-3ae6-d7bd-296c-0c39d194464b@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0cfd73bb-3ae6-d7bd-296c-0c39d194464b@quicinc.com>
Precedence: bulk

On Mon, Aug 14, 2023 at 09:43:37PM +0530, Sibi Sankar wrote:
> Hey Sudeep,
> 
> On 8/14/23 14:55, Sudeep Holla wrote:
> > On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote:
> > > The perf power scale value would currently be reported as bogowatts if the
> > > platform firmware supports microwatt power scale and meets the perf major
> > > version requirements. Fix this by populating version information in the
> > > driver private data before the call to protocol attributes is made.
> > > 
> > > CC: Chandra Sekhar Lingutla <quic_lingutla@quicinc.com>
> > > Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts")
> > > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> > > ---
> > >   drivers/firmware/arm_scmi/perf.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> > > index c0cd556fbaae..30dedd6ebfde 100644
> > > --- a/drivers/firmware/arm_scmi/perf.c
> > > +++ b/drivers/firmware/arm_scmi/perf.c
> > > @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
> > 
> > Please rebase any patch when posting upstream on upstream kernel tree.
> > This definitely looks like some downstream tree. I will adjust and apply
> > this time. This file never crossed 1000 line and this patch indicates
> > otherwise, so I am sure Qcom has some downstream changes in this file now.
> 
> Thanks for taking time to review the patch but zero points for the ^^
> deduction lol. The correct phrasing would be v6.5 rc6 hasn't crossed 1k
> lines but the patch was based on next-20230809 which has the perf level
> indexing mode support in addition :)

You are right. Cristian reminded me about v3.2 perf changes in -next after
I replied on this thread. I saw this as fix and was looking at only upstream
tree and this didn't apply cleanly.

-- 
Regards,
Sudeep