Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Tue, 15 Aug 2023 00:06:15 +0300
To:     TY Chang <tychang@realtek.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] pinctrl: realtek: Add pinctrl driver for RTD1315E
Message-ID: <ZNqXRyryCSRTM0IA@surfacebook.localdomain>
References: <20230726090409.16606-1-tychang@realtek.com>
 <20230726090409.16606-3-tychang@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230726090409.16606-3-tychang@realtek.com>
Precedence: bulk

Wed, Jul 26, 2023 at 05:04:04PM +0800, TY Chang kirjoitti:
> Add RTD1315E support using realtek common pinctrl driver.

...

> +config PINCTRL_RTD1315E
> +	tristate "Realtek DHC 1315E pin controller driver"

> +	depends on PINCTRL_RTD

Why not select and the above be hidden symbol?

...

> +#include <linux/module.h>

> +#include <linux/of.h>

Not used. Use correct headers

> +#include <linux/platform_device.h>

+ Blank line

> +#include <linux/pinctrl/pinctrl.h>

Make use of struct pinconfig, struct pinfunction and respective PINCTRL_PIN*()
macros.

...

> +#define RTD1315E_GROUP(_name) \
> +	{ \
> +		.name = # _name, \
> +		.pins = rtd1315e_ ## _name ## _pins, \
> +		.num_pins = ARRAY_SIZE(rtd1315e_ ## _name ## _pins), \
> +	}

NIH PINCTRL_PINGROUP().

...

> +#define RTD1315E_FUNC(_name) \
> +	{ \
> +		.name = # _name, \
> +		.groups = rtd1315e_ ## _name ## _groups, \
> +		.num_groups = ARRAY_SIZE(rtd1315e_ ## _name ## _groups), \
> +	}

NIH PINCTRL_PINFUNCTION().

...

> +static const struct of_device_id rtd1315e_pinctrl_of_match[] = {
> +	{ .compatible = "realtek,rtd13xxe-pinctrl", },

> +	{},

No comma for the terminator entry.

> +};

...

Same comments for all new drivers in the series.

-- 
With Best Regards,
Andy Shevchenko