Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp841700rdb; Tue, 15 Aug 2023 13:52:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmJU+oxHqffNwNWmU52CcN6Bse1s5alWKJSwaz3FqI/Vr/1XYuA/z+fQMjH/QDhM5+/xzX X-Received: by 2002:a05:6a00:883:b0:64f:35c8:8584 with SMTP id q3-20020a056a00088300b0064f35c88584mr18650284pfj.18.1692132727178; Tue, 15 Aug 2023 13:52:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692132727; cv=none; d=google.com; s=arc-20160816; b=w5UBX9scdgXzfXee0Oz3V9h5aarVwhj4V3Op+93UVnUJL/7Xv/y5oBNvR6m8H0LnB8 vqpZ5cyLt//ZiO2lfKUXB4pWWcmE17A7z3xQsBHPcDPpnehEkFiBPLDLp/6ecK6Da7LC gPOUGibo+JaDsiicoxLY4dtBqfRqP0mBGM3zV7SemnJ7pBa47VXkMlWL5aEBsc88pp4f WfhpiFThxhfT4weZwVDgO50d73cyaLR6KxKFUJNov03qtcW9SKyZD9QMW3fWUV1xJ9J4 2vspzVnySzUAKlsfEU88giJ45DH4cTPyO3M6snMyxZCGAS9QTAnXWku8rQHr3kkFKuBV obcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=XfpuzS2f1A8mPNmR5sOFIH0cI0nDKoMJ/s8SmJlWLyY=; fh=AEQwNWUX95+17oE2gonUJMg4USWnntviomgZRHZVvpE=; b=zN3QtCUor9cjQOVT3dhxO9UrNsli7HfHKJBLOKh/lQ1N0IomXmoiuMUkSkafPM58iu aN8z1uqHTom3MSvyLAVfCqgNiBpAul4QQ7p52xHlAE6CDAHF2fbKd9rBgBYXn+So8Xzb RYN6qjQm9vaM0X2nfC+bqf8GmhDpxjyTVuvt+AYAVASi6nb8zpUqrDKizDjFQicd8UKb iDo5qBboVkz/xVmOApAEZ8hc3UcYRzY4njd/XEm/REnEV6JFW29oUu5YFC+FQH/NbiU6 rNbElJyfaSWtt9+KIjb2HR3wWrNAIiOmc1qQWOg+qXynPCpB5vpK1qzaXYaOu5Pz2Yw+ Duig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WdOFKWFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq27-20020a056a00331b00b00675807330bfsi478383pfb.194.2023.08.15.13.51.54; Tue, 15 Aug 2023 13:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WdOFKWFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234119AbjHOCOn (ORCPT + 99 others); Mon, 14 Aug 2023 22:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234195AbjHOCOX (ORCPT ); Mon, 14 Aug 2023 22:14:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CB19BE; Mon, 14 Aug 2023 19:14:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FB49655ED; Tue, 15 Aug 2023 02:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11F35C433C8; Tue, 15 Aug 2023 02:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692065661; bh=wZZWakoCmL8C3Trm3epJ6X7aLlQiZ7J0bSsO2dW93DU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WdOFKWFdyz2QhDwtfw64yNKrXMjeg5uxuwhFEvavcbs36k4JR3G/4htv26sRTW+Xk V7QgzNTiw2xwA7PEHpnz183aew7lmWSW7BafLk7hr5V5fGLrobBnVLX8CcLyPfuQPQ 79pi2Ej3Cx7RpE8idfgk9b98jJz50Dxa1HEafagy1ZixdxVt78mtIp4rz6W0bQkZDr fy+/fZzvLKKdwKE9Tu/XjoenbEDpHvVWVrGWNMFSyqIRA0QXfKiog04D/c4t4gwZZW 7eWQK5YFkIYRcAGVdU2fvQ2AMpfcAUy0icvVRCwoUrYeiNLkmaLeq+vMxeFmZGimp5 rVGb+4xHexdYQ== Message-ID: Date: Tue, 15 Aug 2023 11:14:19 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-11-john.g.garry@oracle.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230814141022.36875-11-john.g.garry@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/14/23 23:10, John Garry wrote: > Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new > driver"), sas_ata_task.retry_count is never set, so delete it and the > reference in asd_build_ata_ascb(). > > Signed-off-by: John Garry Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research