Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be>
 <94dd2237-2a4a-fb45-ceb1-f224fafd4e36@ideasonboard.com>
In-Reply-To: <94dd2237-2a4a-fb45-ceb1-f224fafd4e36@ideasonboard.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 16 Aug 2023 10:17:26 +0200
Message-ID: <CAMuHMdWkqQ0v0k4a-JDo+nqC4=t9jRmjFCmo=og64e8hJ4iHmQ@mail.gmail.com>
Subject: Re: [PATCH] i2c: Make I2C_ATR invisible
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Tomi,

On Tue, Aug 15, 2023 at 6:00 PM Tomi Valkeinen
<tomi.valkeinen@ideasonboard.com> wrote:
> On 15/08/2023 18:29, Geert Uytterhoeven wrote:
> > I2C Address Translator (ATR) support is not a stand-alone driver, but a
> > library.  All of its users select I2C_ATR.  Hence there is no need for
> > the user to enable this symbol manually, except when compile-testing.
> >
> > Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Do we care yet about out-of-tree drivers that need this functionality?
> > ---
> >   drivers/i2c/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> > index c6d1a345ea6d8aee..9388823bb0bb960c 100644
> > --- a/drivers/i2c/Kconfig
> > +++ b/drivers/i2c/Kconfig
> > @@ -72,7 +72,7 @@ config I2C_MUX
> >   source "drivers/i2c/muxes/Kconfig"
> >
> >   config I2C_ATR
> > -     tristate "I2C Address Translator (ATR) support"
> > +     tristate "I2C Address Translator (ATR) support" if COMPILE_TEST
> >       help
> >         Enable support for I2C Address Translator (ATR) chips.
> >
>
> Isn't this normally done with just "tristate", without the text? Is
> there a need to make configs manually selectable when compile-test is
> enabled?

"tristate" without the text would make the symbol invisible, too.
However, then the user has no way to enable it for compile-testing
(unless also enabling one of the symbols that select it, which may
 not be possible due to other dependencies).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds