Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp1195273rdb; Wed, 16 Aug 2023 04:52:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHu9zen5kD5JF36Cd42Owv6ixuYK5EcRIh3dJAzlAKy3fENfpX15UMNj/S6onNPpSc5h/ed X-Received: by 2002:a17:906:7fc8:b0:99b:ca24:ce33 with SMTP id r8-20020a1709067fc800b0099bca24ce33mr1177332ejs.31.1692186737198; Wed, 16 Aug 2023 04:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692186737; cv=none; d=google.com; s=arc-20160816; b=H7+PtL0M14B2aPXytpS9B5Qa6CrpRspk1koAA5HTae7tAOGx8JGKeF1nWCeubEPujj uCO35r3kj2MuOmWwhtxZk458VDJCRCAeAkqHRYWtgsW1fkG9TWUaLXAUfhJ+87TQbnEQ pnk3JcUlB5Jl4w9bAjIlC1Qb5ieLYWoUgFuZoxXTlSRvKy+svSCgGQYWsMPjfP+mr0ZZ dq8/FvtTwk+fJs6dCxjRMbIHCPogJ/qHVK9RvWDS+bWMc6PNpRKwl+2948EUdTIWEeyL +NTbP7RZo5XNJT/oG3Zqedb9/t90gyk9LInhfLtGYXph3hd8rYVN9RYE1p7kogKa6+Xa a9Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=M3+S1P3XVyx6tDt4+HbMPFp1obFa5jvMpoym4gXVtEY=; fh=XWQGQsVABt0LWo9B8sMHta0kXuRGeuoY3JFxpGdmxaU=; b=D1KbLi/Ye9TJ3aCSo9uMdCia/dtkEjzNQrT3Oo2Cud1x2VcePgxTRQ0CpIb1wwGb/9 3C43quMBfBd40lyBVHxsK5PAhVQoTOyjjt6RAngwPerAOyChfQ02eHCN/77sxyRgqPAZ WLJ8C3WdoLWghqGqZs6hBvTp6lViz/uhTKm01OVo742M0QcMU5pEE2hIpNTYBurB566L +2pWYejH9POmU+gguYkNkVzlV0yUfmxpbZxZtN3LFNfRVhH6YqhTjwaRUI5NlKDa1Ugd 7ZwqmydZ+IV71pwnRAqtZQJhU4p+OaM8bGzxNCd4e0WJzelMmdtgtUnXTnwvw/8qRdCV 1oIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a170906488e00b0099d804da2ebsi8212182ejq.503.2023.08.16.04.51.52; Wed, 16 Aug 2023 04:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236189AbjHOJ2w (ORCPT + 99 others); Tue, 15 Aug 2023 05:28:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235082AbjHOJ1t (ORCPT ); Tue, 15 Aug 2023 05:27:49 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077F5113; Tue, 15 Aug 2023 02:27:48 -0700 (PDT) Received: from canpemm100004.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RQ5Sx5RX0zFqdC; Tue, 15 Aug 2023 17:24:49 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm100004.china.huawei.com (7.192.105.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 15 Aug 2023 17:27:45 +0800 Subject: Re: [PATCH 01/10] scsi: libsas: Delete sas_ha_struct.lldd_module To: John Garry , , , , , CC: , , References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-2-john.g.garry@oracle.com> From: Jason Yan Message-ID: <286d4e9a-8eea-74c0-926d-ace968cfa435@huawei.com> Date: Tue, 15 Aug 2023 17:27:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230814141022.36875-2-john.g.garry@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm100004.china.huawei.com (7.192.105.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/14 22:10, John Garry wrote: > Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new > driver"), sas_ha_struct.lldd_module has only ever been set, so remove it. > > Struct scsi_host_template already has a reference to the LLD driver > module as to stop the driver being removed unexpectedly. > > Signed-off-by: John Garry > --- > drivers/scsi/aic94xx/aic94xx_init.c | 1 - > drivers/scsi/hisi_sas/hisi_sas_main.c | 1 - > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 - > drivers/scsi/isci/init.c | 1 - > drivers/scsi/mvsas/mv_init.c | 1 - > drivers/scsi/pm8001/pm8001_init.c | 1 - > include/scsi/libsas.h | 1 - > 7 files changed, 7 deletions(-) Reviewed-by: Jason Yan