Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Oleg Nesterov' <oleg@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>
CC:     Petr Skocik <pskocik@gmail.com>, Kees Cook <keescook@chromium.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Marco Elver" <elver@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] signal: Fix the error return of kill -1
Thread-Topic: [PATCH] signal: Fix the error return of kill -1
Thread-Index: AQHZzsZurwDqks8Mx0Ka5moH+T06/q/rb+fw
Date:   Tue, 15 Aug 2023 14:47:07 +0000
Message-ID: <3b14ae8091e3403bbc4ef1bee6dcf4f6@AcuMS.aculab.com>
References: <20221122161240.137570-1-pskocik@gmail.com>
 <202211220913.AF86992@keescook>
 <d2d508b7-f267-0fe6-1b56-4292c95355a7@gmail.com>
 <878rai7u0l.fsf@email.froward.int.ebiederm.org>
 <336ae9be-c66c-d87f-61fe-b916e9f04ffc@gmail.com>
 <87pm3t2rvl.fsf@email.froward.int.ebiederm.org>
 <87jzu12pjh.fsf_-_@email.froward.int.ebiederm.org>
 <20230814140652.GA30596@redhat.com> <20230814154351.GA4203@redhat.com>
In-Reply-To: <20230814154351.GA4203@redhat.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Oleg Nesterov
> Sent: 14 August 2023 16:44
...
> Even simpler
> 
> 	} else {
> 		struct task_struct * p;
> 		bool success = false;
> 		int err = -ESRCH;

		int err;
		ret = -ESRCH;

> 
> 		for_each_process(p) {
> 			if (task_pid_vnr(p) > 1 &&
> 					!same_thread_group(p, current)) {
> 				err = group_send_sig_info(sig, info, p,
> 							  PIDTYPE_MAX);
> 				success |= !err;
> 			}
> 		}
> 		ret = success ? 0 : err;
> 	}

or maybe even:
	} else {
		struct task_struct * p;
		int err;
		ret = -ESRCH;

		for_each_process(p) {
			if (task_pid_vnr(p) > 1 &&
					!same_thread_group(p, current)) {
				err = group_send_sig_info(sig, info, p,
							  PIDTYPE_MAX);
				if (ret)
					ret = err; 
			}
		}
	}

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)