Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Aug 2023 14:42:04 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] perf test: Add perf record sample filtering test
Message-ID: <ZNu47CYXV0nuav+G@kernel.org>
References: <20230811025822.3859771-1-namhyung@kernel.org>
 <20230811025822.3859771-2-namhyung@kernel.org>
 <ZNu2KrbgFPY69K2+@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNu2KrbgFPY69K2+@kernel.org>
Precedence: bulk

Em Tue, Aug 15, 2023 at 02:30:18PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Aug 10, 2023 at 07:58:22PM -0700, Namhyung Kim escreveu:
> >   $ sudo ./perf test 'sample filter' -v
> >    94: perf record sample filtering (by BPF) tests                     :
> >   --- start ---
> >   test child forked, pid 3817527
> >   Checking BPF-filter privilege
> >   Basic bpf-filter test
> >   Basic bpf-filter test [Success]
> >   Failing bpf-filter test
> >   Error: task-clock event does not have PERF_SAMPLE_CPU
> >   Failing bpf-filter test [Success]
> >   Group bpf-filter test
> >   Error: task-clock event does not have PERF_SAMPLE_CPU
> >   Error: task-clock event does not have PERF_SAMPLE_CODE_PAGE_SIZE
> >   Group bpf-filter test [Success]
> >   test child finished with 0
> >   ---- end ----
> >   perf record sample filtering (by BPF) tests: Ok
> 
> [root@five ~]# perf test -v "by BPF"
>  91: perf record sample filtering (by BPF) tests                     :
> --- start ---
> test child forked, pid 64165
> Checking BPF-filter privilege
> Basic bpf-filter test
>  ffffffff97f4f688
>  ffffffff97f73859
>  ffffffff97412ce6
>  ffffffff976da215
>  ffffffff973a92bf
>  ffffffff97376ad7
>  ffffffff97f73859
<SNIP
>  ffffffff971fdca5
>  ffffffff9737dbc4
>  ffffffff971b4e04
> Basic bpf-filter test [Failed invalid output]
> test child finished with -1
> ---- end ----
> perf record sample filtering (by BPF) tests: FAILED!
> [root@five ~]#
> 
> [root@five ~]# uname -a
> Linux five 6.2.15-100.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu May 11 16:51:53 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
> [root@five ~]# 

Above was on a AMD Ryzen 5950X, the following was on a lenovo t480s,
Intel notebook:

[root@quaco ~]# uname -a
Linux quaco 6.4.7-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Jul 27 20:01:18 UTC 2023 x86_64 GNU/Linux
[root@quaco ~]# perf test "filter"
 30: Filter hist entries                                             : Ok
 36: Filter fds with revents mask in a fdarray                       : Ok
 67: dlfilter C API                                                  : Ok
 91: perf record sample filtering (by BPF) tests                     : Ok
[root@quaco ~]# perf test -v "by BPF"
 91: perf record sample filtering (by BPF) tests                     :
--- start ---
test child forked, pid 273609
Checking BPF-filter privilege
Basic bpf-filter test
Basic bpf-filter test [Success]
Failing bpf-filter test
Error: task-clock event does not have PERF_SAMPLE_CPU
Failing bpf-filter test [Success]
Group bpf-filter test
Error: task-clock event does not have PERF_SAMPLE_CPU
Error: task-clock event does not have PERF_SAMPLE_CODE_PAGE_SIZE
Group bpf-filter test [Success]
test child finished with 0
---- end ----
perf record sample filtering (by BPF) tests: Ok
[root@quaco ~]#