Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp1348397rdb; Wed, 16 Aug 2023 08:58:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLakOEusaPr1iAtw6KmUUzQMf17h/YAUY0EY++ueBG/UvQSnsUGIYFcngUVyd4VccZPCQD X-Received: by 2002:a17:902:ec87:b0:1bb:ce4a:5893 with SMTP id x7-20020a170902ec8700b001bbce4a5893mr2424002plg.30.1692201505120; Wed, 16 Aug 2023 08:58:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692201505; cv=none; d=google.com; s=arc-20160816; b=i2ndwiPUHHyJ2uqDc9gdWNh95Ly6vSHChE0qSERf0lsODS9ho7HLjB1Pb34BHuKNMr bwicuvyyNuCm4ObVhhtvZAzK9yAgBXLKDt5MgTnma5D70uTwDXVZPX2QNGREfpK11O0n mL+LxYOGpMEEq/yHKR2EDE+PxViJ3e3urDkxtLOBPW9ZH9f1xHyhInVFIUEqm7iNRfBS Se2RvTODWTa3uj+dMhjat21F+RLLS5VChNYnq0fVSvGemreRCXs6oUdpPvSguMsdAtXs agVXU5Q1kJVvmhPBHdH/CzAsZ87NBLLCwxN2Qg8e+UvqHdf1W6zltFzWzjYdSfEfb9BX w1Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=QI/pr419vzq9tC0yNUArBUZI1t2YyboLXdeSyZi9u4I=; fh=XWQGQsVABt0LWo9B8sMHta0kXuRGeuoY3JFxpGdmxaU=; b=lAeugy1K3+pErofd3DWARqP3npBtwA3ZKVhgsclH/oI6RJ0da+53jgU4ZvtT/tzWHw aJdPWOCJ1bJAc3fhD7hV3lNLUtNoDI4dHTLeMpP6tIlYJZT16lx46iJYz3twfFY4rfRV 8VTUNF30l8yLpebh1LzViJzlJAOor6K+1quWKZIcMDhAI7EeLjIu5LwIo/JtbmQFOU6n mFdNpFwVXQicwTZV5tgzOlbwC5B+d5X6AlW2P1kYU58mBN5FMci3ra1l8sf804Ydv+52 Nm6AKpYfU1j9CQtKWOe8eDeItKgaMGpmvinLFW1AsjI1FWEXzoFzN55OCZMOnC6KAZ7a qLFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ja2-20020a170902efc200b001bbd5fa7d66si11094393plb.164.2023.08.16.08.58.12; Wed, 16 Aug 2023 08:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236211AbjHOJh7 (ORCPT + 99 others); Tue, 15 Aug 2023 05:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236230AbjHOJhs (ORCPT ); Tue, 15 Aug 2023 05:37:48 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43E4C19A6; Tue, 15 Aug 2023 02:37:47 -0700 (PDT) Received: from canpemm100004.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RQ5gj6qvBztS6c; Tue, 15 Aug 2023 17:34:09 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm100004.china.huawei.com (7.192.105.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 15 Aug 2023 17:37:45 +0800 Subject: Re: [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count To: John Garry , , , , , CC: , , References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-11-john.g.garry@oracle.com> From: Jason Yan Message-ID: <27eeb032-c22f-127f-e54a-58d8e48581de@huawei.com> Date: Tue, 15 Aug 2023 17:37:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230814141022.36875-11-john.g.garry@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm100004.china.huawei.com (7.192.105.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/14 22:10, John Garry wrote: > Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new > driver"), sas_ata_task.retry_count is never set, so delete it and the > reference in asd_build_ata_ascb(). > > Signed-off-by: John Garry > --- > drivers/scsi/aic94xx/aic94xx_task.c | 2 +- > include/scsi/libsas.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Jason Yan