Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp1449927rdb; Wed, 16 Aug 2023 11:43:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2oBS+xsyMm8nvzI+qg+Hi7pPmwTDqwM8URD/rYl5MeI+k0jMbOBuvvniWSoRCe6piLoWL X-Received: by 2002:a05:6512:b14:b0:4fb:8616:7a03 with SMTP id w20-20020a0565120b1400b004fb86167a03mr2584033lfu.4.1692211404617; Wed, 16 Aug 2023 11:43:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692211404; cv=none; d=google.com; s=arc-20160816; b=0jbLdxDfOciTt/mv7IorGwYjt5V5eJdo+OwJRxZpi7RmzF2Dr31rPuQcP5UM9s4Fu5 H4GTk7nf+t22T4ltqLmQ6dz30r9n58GBzI09EEcqOtt1dIAGwePt7Nn+TrWq0xPA1Tn7 PDuLpGaHYC8IXrJi1yNEr978nh/ahRD5+PODtErM0etTRyYNmAtQZGycsweSuiGPBTWU +8HsGMP1q8wo/avlDhwXi4/2npE+uSyeQRMcj8g6tdebUFI9s13paEW6eFVdAuLsWvAu vVzP2dHCTx1H6ZMgiASjSb+NTEjSYpjuRW80dUla5/7l48JpY5p3SSlyLkBS5Ufu9NUk fSVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gml6w22pDLU0lBZkHIxs0ifw2kAmXKkB85Z5R6O8kEk=; fh=CU8fkrYosj76RaH2ingCAv7sW10C6PKGdtKh7oIwmAc=; b=lLzXjPzYzjg33T1i1lP13somJQabNhOD4JXstXnZarJbzJwbhMDpBCDoGRdFiHmqHx fhPdohUMCgPbp+K5yqzeslAuGxIc0n/nTuwNpQHcSO77AE5bLVmSCcvwb/DuBaRiJFXV tI1ROwGGIsNc5Rt8QN6Zqd/oixcso11AuZxnrsai6prUXOegjkxbu94Ol8fDOOMcq1Hx W70H8dQmt3/e82fA7AB8s1dar40mf+Ej4of97erO4p7fAzZ1Jd5CWGpUjFsnUB7ttcKB v291T9KB40YnSsdrOMW9sFsIEiNVPfU5NwCJ3eJuy9bVi/A8otDBEWY0oUgBuraEfYjF 8cmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020aa7dd03000000b0052318dbe3b0si7118151edv.345.2023.08.16.11.42.59; Wed, 16 Aug 2023 11:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235936AbjHOJLE (ORCPT + 99 others); Tue, 15 Aug 2023 05:11:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235965AbjHOJKP (ORCPT ); Tue, 15 Aug 2023 05:10:15 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AFEC110C; Tue, 15 Aug 2023 02:09:58 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qVq3o-0002fa-00; Tue, 15 Aug 2023 11:09:56 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 1E949C01A8; Tue, 15 Aug 2023 10:26:48 +0200 (CEST) Date: Tue, 15 Aug 2023 10:26:48 +0200 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/3] mips: remove unneeded #include Message-ID: References: <20230807153243.996262-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807153243.996262-1-masahiroy@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 12:32:41AM +0900, Masahiro Yamada wrote: > There is no EXPORT_SYMBOL line there, hence #include > is unneeded. > > Signed-off-by: Masahiro Yamada > --- > > arch/mips/kernel/octeon_switch.S | 1 - > arch/mips/kernel/r2300_switch.S | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/mips/kernel/octeon_switch.S b/arch/mips/kernel/octeon_switch.S > index 9b7c8ab6f08c..447a3ea14aa1 100644 > --- a/arch/mips/kernel/octeon_switch.S > +++ b/arch/mips/kernel/octeon_switch.S > @@ -11,7 +11,6 @@ > * written by Carsten Langgaard, carstenl@mips.com > */ > #include > -#include > #include > #include > #include > diff --git a/arch/mips/kernel/r2300_switch.S b/arch/mips/kernel/r2300_switch.S > index 71b1aafae1bb..48e63943e6f7 100644 > --- a/arch/mips/kernel/r2300_switch.S > +++ b/arch/mips/kernel/r2300_switch.S > @@ -13,7 +13,6 @@ > */ > #include > #include > -#include > #include > #include > #include > -- > 2.39.2 applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]