Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v6] selftests/clone3: Fix broken test under
 !CONFIG_TIME_NS
To:     Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Christian Brauner <brauner@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <1689066814-13295-1-git-send-email-yangtiezhu@loongson.cn>
Cc:     linux-kselftest@vger.kernel.org, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <0560a851-5e8c-d82a-8445-a16a92b967c9@loongson.cn>
Date:   Thu, 17 Aug 2023 15:22:31 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1689066814-13295-1-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shuah,

On 07/11/2023 05:13 PM, Tiezhu Yang wrote:
> When execute the following command to test clone3 under !CONFIG_TIME_NS:
>
>   # make headers && cd tools/testing/selftests/clone3 && make && ./clone3
>
> we can see the following error info:
>
>   # [7538] Trying clone3() with flags 0x80 (size 0)
>   # Invalid argument - Failed to create new process
>   # [7538] clone3() with flags says: -22 expected 0
>   not ok 18 [7538] Result (-22) is different than expected (0)
>   ...
>   # Totals: pass:18 fail:1 xfail:0 xpass:0 skip:0 error:0
>
> This is because if CONFIG_TIME_NS is not set, but the flag
> CLONE_NEWTIME (0x80) is used to clone a time namespace, it
> will return -EINVAL in copy_time_ns().
>
> If kernel does not support CONFIG_TIME_NS, /proc/self/ns/time
> will be not exist, and then we should skip clone3() test with
> CLONE_NEWTIME.
>
> With this patch under !CONFIG_TIME_NS:
>
>   # make headers && cd tools/testing/selftests/clone3 && make && ./clone3
>   ...
>   # Time namespaces are not supported
>   ok 18 # SKIP Skipping clone3() with CLONE_NEWTIME
>   ...
>   # Totals: pass:18 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>
> v6: Rebase on 6.5-rc1 and update the commit message
>
>  tools/testing/selftests/clone3/clone3.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>

Hi Shuah,

Any comments? I guess this should go through the linux-kselftest tree.

Thanks,
Tiezhu