Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fa02b18-7e41-eaea-f054-6842f6e310c6@arm.com>
Date:   Wed, 16 Aug 2023 15:05:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table
Content-Language: en-US
To:     Lukasz Luba <lukasz.luba@arm.com>, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, rafael@kernel.org
Cc:     rui.zhang@intel.com, amit.kucheria@verdurent.com,
        amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
        viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz,
        Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
        mhiramat@kernel.org
References: <20230721155022.2339982-1-lukasz.luba@arm.com>
 <20230721155022.2339982-9-lukasz.luba@arm.com>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
In-Reply-To: <20230721155022.2339982-9-lukasz.luba@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/07/2023 17:50, Lukasz Luba wrote:
> This patch introduces the new feature: modifiable EM perf_state table.

nit pick: The first sentence doesn't add any information. I would skip it.

[...]

> The runtime modifiable EM data is used by the Energy Aware Scheduler (EAS)
> for the task placement. The EAS is the only user of the 'runtime
> modifiable EM'. 

The runtime modifiable EM is currently only used ...
The you can skip the next sentence: "The EAS is the only user ..."

All the other users (thermal, etc.) are still using the
> default (basic) EM. This fact drove the design of this feature.

[...]