Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp2153758rdb; Thu, 17 Aug 2023 12:17:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBo2pm716Ae93zb2hb0COv/WGdljFzi5eFPr2GCbNfprhmh2jBM5A8FEzT4wLlblV9ngHs X-Received: by 2002:a05:6a20:429f:b0:132:c07d:9dd2 with SMTP id o31-20020a056a20429f00b00132c07d9dd2mr728086pzj.39.1692299838274; Thu, 17 Aug 2023 12:17:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692299838; cv=none; d=google.com; s=arc-20160816; b=rd3EYKUkTQJjIGx+CXl8siKBdNYcpxUOKt11aSN83fON0tg9xaU6BXdai1GsN4icQy WcLPUB3S3hDdty/Wj3CCFboiLieXBTSZBRcoACKtsVQNjNw+G+QumA2Svf45JDXnXOPC 4STkr5XBc/b/UDh7KdGcFickxnuNLig/maFFu5DYl8HujwGhpZ9Z8H19IF/ClhXQeHYw /36Obd3qfsXKZ4irFmcprm/N+zUL6Zwelsxm4YK8nG8tansbrECzOE1BhJkZvMuBcs/G bAV0YYsE7vCffdpF9rWKhP+zaB6cVBltlQd8UIeciFuhf2rDtid/RR4ksZuWER9gykv/ VAiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LQS03tngKyRC5S+ztrA+pi3kJ9UDlyq1Yb+DXw1lR9A=; fh=b17iD9M0sz03ENQXCBPyKntdQoAtEuMcIbgjRusiXkk=; b=apIZzEbRiQQ2AiJDw5KayAZ4Ks9Wuy8F4IZ5ol4jocVXUa59SBEYhTqK0rjWBNNq3F zXFk5FlJXuYm2L2wGZPBIVr6A0imZqUXdlxMAF5BxYnmj4571Z68ipI4cfUVl2922efX w2DQMtYjD+cjYPwJzB3lpcWzLcDMHQUKLbFiLlC9NyqvqFVKZ8fbargvhhFHwV1NKCIw PPx0/r7XjGpsJnyzj2OaKNNwuzkEZp2nL9gf5fN9KG6nwLMflegRsjRtkwxPSr971sH2 EKROplxakAYMaLNhxqAQ9k3qD3kcWn4BNuwReZ63Jt/e14HjWRsIEQwnrX3tLtt7B9+O 1PpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pvMT8Jcn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f14-20020a056a00228e00b0064378bea76dsi137632pfe.239.2023.08.17.12.16.58; Thu, 17 Aug 2023 12:17:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pvMT8Jcn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237514AbjHOOKy (ORCPT + 99 others); Tue, 15 Aug 2023 10:10:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237523AbjHOOKd (ORCPT ); Tue, 15 Aug 2023 10:10:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D0B3199A for ; Tue, 15 Aug 2023 07:10:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E04161E53 for ; Tue, 15 Aug 2023 14:10:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9358C433C7; Tue, 15 Aug 2023 14:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692108632; bh=n5ZUySZEZiqsQq5qoUoRbN2WfkDeGQmpgZO6gsSVgNU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pvMT8JcnQZj7OZmeLN4OT/RqwDIhHXrGoPSW8qC8zzDbSsyIch1Rv8GKkiGY7DkPR cTIoVmCUU/5zjeeHADYvvuuQj08CU4VD2TJzinH8qRNYMwz5N5GURwwZOEEEHZvLAF yhp3rpbsL8tMQsulZwbJ0sENQc81fWY7bx0Akhhru9ySYSuq6ewC9rTw4fc7MN6ba4 X2wCXy4KqRNvCDqJib5ufDckzKOScVjVxRqL79YIvbS6bRSYsVkHm0ojoRA8he0zqs r2FeqkPyvPqJ6kl8TLFwdtJJ/1U0z67s6fDCkmZ3ZfchU/GpsrQVzk+pxlx59NNXRx OZAGmxg0PGNqw== Date: Tue, 15 Aug 2023 15:10:25 +0100 From: Mark Brown To: Krzysztof Kozlowski Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nathan Chancellor , Nick Desaulniers , Tom Rix , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, llvm@lists.linux.dev, Andi Shyti Subject: Re: [PATCH 1/4] ASoC: aw88261: Fix unitialized ret of aw88261_reg_update() Message-ID: <7b35b3b6-7eab-4652-9a16-851a060350bd@sirena.org.uk> References: <20230810104749.164827-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vj9n6GWKkaE+J3Ue" Content-Disposition: inline In-Reply-To: <20230810104749.164827-1-krzysztof.kozlowski@linaro.org> X-Cookie: Darth Vader sleeps with a Teddywookie. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vj9n6GWKkaE+J3Ue Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 10, 2023 at 12:47:43PM +0200, Krzysztof Kozlowski wrote: > There is a branch in if() clause where aw88261_reg_update() could return > uninitialized value. Pounted out by W=1 clang build: This series appears to have two copies of every patch which *look* similar but I'm not 100% sure if that's the case or in general what's going on - could you please resend a clean copy, it's probably easier than figuring it out? --vj9n6GWKkaE+J3Ue Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTbh1AACgkQJNaLcl1U h9Db2wgAhKl6awfKbl76YkckQHA0qEwrCC3ehM9pJoMcPKMh3Sc9f3FMZrk4XmRg sPzgcu1JgnUD/G3svs82wur5Kocs8gpAxTiBPonVpko0iILOA6IcELf8Rj3sXVOL jUS4Qz89yi5zhrTcEQwZm+9FfrXwmeeRNef1KnNHEbG+24KUPVWcRxu/mWfvTPk5 WFL5fgeccSniy5L8pWNC464fRdUzoFSLNxR7/SXtiFjoGbXGCDkRsGNAiMWskO6h MuFOlNeK8dvtwoVNm06CEk1MWftPzkmRQn6WHb1YjsWU4akwwFXyDRLeTVAfmQCU lGuevRFzUsBb2FxR8FJyuJOpeRpAfQ== =8N2T -----END PGP SIGNATURE----- --vj9n6GWKkaE+J3Ue--