Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758675AbXKCT0S (ORCPT ); Sat, 3 Nov 2007 15:26:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755402AbXKCT0K (ORCPT ); Sat, 3 Nov 2007 15:26:10 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:55749 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755173AbXKCT0J (ORCPT ); Sat, 3 Nov 2007 15:26:09 -0400 Date: Sat, 3 Nov 2007 12:26:07 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Hugh Dickins cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] slub: fix leakage In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 21 On Sat, 3 Nov 2007, Hugh Dickins wrote: > On Sat, 3 Nov 2007, Christoph Lameter wrote: > > On Sat, 3 Nov 2007, Hugh Dickins wrote: > > > > > Which fixes the leakage: Objects and Partials then remain stable. > > > > Well this code is just an optimization for a rare case. > > Your patch may not handle the debug situation the right way. > > Oh? How? If SLAB_DEBUG is set then your patch does not do the proper checks for the object, tracing information is not written and the poisoning is not done. See alloc_debug_processing(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/