Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp2479910rdb; Fri, 18 Aug 2023 01:26:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3YMhmMcUjLCIOaeFH+Sd9Fo7nW3JVB8QoT/QGtROYbP2GTP4Z9a8filrFyj3Lk5TTUiyF X-Received: by 2002:a05:6512:1094:b0:4fb:821e:2241 with SMTP id j20-20020a056512109400b004fb821e2241mr1689683lfg.23.1692347219429; Fri, 18 Aug 2023 01:26:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692347219; cv=none; d=google.com; s=arc-20160816; b=RXqW6OOyi68iE0rLDqXUng9aC51iXdo+Xc9MKyThEoM/JuCHDNRHCJ9CAoWeeItvpF Af3wXPNmHSIHluN8sn7binKOmAshzEMocjUvuOD0x7p5Zcxeqw8XDU++A4f5bSIY42nI dCNzBWWg5QLCgCsm+ev/EiZm5EHXEx1/XbvMFbDojfZ9rpDKVy6tWYMnrRSWmGZQ1qpv 42ljn4EwkpjFEGyOAifJAAh+fsNzmfWWtWT3+0A59DKiYSsEYW68t/JRqnqIqxEz4Bm8 pX9jsDIOpjKAERA1UA/fDwvq1jeIKS9JhMN9kdJR6gYKEWDg4sGuXlMw8JcMsufRP4KG LYGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=B/cPyNp3V9gxqEHcGJ8tGTvPRD18w/h3cnx+mmswZzY=; fh=QZEQqjtUaJcQQaI9Engski70aLPKLWHGK3la3zMSoic=; b=HO4ZS0p5YizHneD01Zkc0ZoqQSmRuWG6eUyb5qKp8bdejIW3EjllLyxHkQ3VLo/8E9 Uj+eqw1rGFh42wvrI+CnQk0MMPnsFuZzZqROEa6F92FBXrWZ6JFw5cOuZY+/G+uLFF0S 8B6AE6ApUXVZ8ftnroRGsquDDC6X0w+cnS0ing1YEiMde/kjYVeUHxyxD09yIIvkXXg6 ct/XsLvtxxxedKnXkEUXmLYcqoc9TVdql6Nq8/cwMhMMUe6fGzsdrkvXUlEMona0xEq5 B219zRibNxBaYzuGev08YTN2xhuRZrWgHJY4sMIbh8F58Jvn9EaBZ2EjCCVq4a+7+9+y ALSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E6JrJfvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020aa7c1ca000000b005257e2b80bbsi922159edp.608.2023.08.18.01.26.27; Fri, 18 Aug 2023 01:26:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E6JrJfvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239127AbjHOUoR (ORCPT + 99 others); Tue, 15 Aug 2023 16:44:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239175AbjHOUnn (ORCPT ); Tue, 15 Aug 2023 16:43:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDA7138 for ; Tue, 15 Aug 2023 13:43:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93E0C6551A for ; Tue, 15 Aug 2023 20:41:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98129C433C9; Tue, 15 Aug 2023 20:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692132112; bh=T2szHddILlEWvuY7nP42GFOIJiTikof8i6XOhjiln4Q=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=E6JrJfvP4wLCyB+DCnASM6bIPrghcTOv+3tDGEN58EgHRrwcyte2EUi7dnq1yG5Yt F8FEnf/NM6wLK9qi5AnA4T16WiGvPKoDl1uPluCq0WGIWIInHVoM/tcxKpY8FGhVfE dUNS5RIBo5+mSC0yRYZ8H6V/CdxEslflJldayzSjlcjd9ekY5Q1Dx/hWdpKzWqBaU/ QcnqDvgMiVxxoGbc60nMZM+eoo1mKjvYNawoZg0CGUw0nlRcIJNIbX9XRzPKnXDlyS 5dqEUTIN2UENY3rwjzCrf/YbSjjXwhzUAsbFQyRLL1ksEyWrfIKXtA0nT0rKsghItg 6OAN+xN8VqQuA== From: Mark Brown To: Simon Trimmer , Charles Keepax , Richard Fitzgerald , Vlad Karpovich Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Ricardo Rivera-Matos In-Reply-To: <20230815172908.3454056-1-vkarpovi@opensource.cirrus.com> References: <20230804165212.236822-1-vkarpovi@opensource.cirrus.com> <20230815172908.3454056-1-vkarpovi@opensource.cirrus.com> Subject: Re: [PATCH] firmware: cs_dsp: Fix new control name check Message-Id: <169213211034.572973.3501945311233979660.b4-ty@kernel.org> Date: Tue, 15 Aug 2023 21:41:50 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-034f2 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Aug 2023 12:29:08 -0500, Vlad Karpovich wrote: > Before adding a new FW control, its name is checked against > existing controls list. But the string length in strncmp used > to compare controls names is taken from the list, so if beginnings > of the controls are matching, then the new control is not created. > For example, if CAL_R control already exists, CAL_R_SELECTED > is not created. > The fix is to compare string lengths as well. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] firmware: cs_dsp: Fix new control name check commit: 7ac1102b227b36550452b663fd39ab1c09378a95 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark