Received: by 2002:a05:7412:bb8d:b0:d7:7d3a:4fe2 with SMTP id js13csp2661110rdb; Fri, 18 Aug 2023 07:07:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8buKLiLX4Jzp+OOV7pMHP6rhMYqe6xmjU9a0rQtAnwEO538HUrgGZNdFc8T4RcdWz9aA1 X-Received: by 2002:a05:6a20:244d:b0:140:2805:6cc9 with SMTP id t13-20020a056a20244d00b0014028056cc9mr3548811pzc.57.1692367653263; Fri, 18 Aug 2023 07:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692367653; cv=none; d=google.com; s=arc-20160816; b=istRXvJYSQRydzBtycimbZpWvGURYSKJ52FA+iGmtySczV7icxOYi90pcvbQDE+ZzB pQKDRzWqZucD8SJmBGnmQ8YV2AhkQZSS3jFptFlzLuVSheUE/qmPuuT8CIpBNxwl7Ym4 7Y9KPQZ5DhBzSZsQT4i/YQ4Aw/hZ01t2MOrnDWn4XEdEpt32QZCIXDNjdYQDv3Bn8XQg VGWD6YmwE55qJA4/yY7Q/W66NFpFGSuu58TJ5SaJ9zogWh2dJwBV/PJbWMyl0Ccvra/G N02SZjXWLztWNmmR92+ZqTLr9MaOMrLOel7K296+PKPs9E7COrmBJwf8OY9CvgF2XOG4 bnQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vJR/YE4jLhlvafKUQzTk10zMBj33RH6GySsj83iQLmk=; fh=akTS0Wq8jEms5e4CIjRZ2klQmCylMzrjhYuxow3r01E=; b=OjVG3qp41rOWGubW73fq/Un+3f4HeI/VU7vVp/ee6QwjU/BIM0731BDYPx5ib6qqhs qiTsk6g210eietx1HX17K1vIRUGHLNo+BoSTx4rZD0bQky4HlnlRkg4EzuB5nYFuVT88 tJu2snc13HrrDoJOKWXFDjfR/iSPwIl4nMQrYU6AnnxZjqpM8JAUYAgUpCAlpDw53Ynp OWZbwY0iBzCOT86u7eSvRg1Vt2ffeeYLWCynXiScUfRQgG03BksY/RVNFKOrvXrirwts I5Q1qZYTUjzjI1RoG4nzcQwQP8MjDXZUk2lzsXryAFo0i+gueNxEaFSoX+mgV124jBsU x9Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=aMhn3nzy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l62-20020a639141000000b0056951909cbdsi879636pge.302.2023.08.18.07.07.19; Fri, 18 Aug 2023 07:07:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=aMhn3nzy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354428AbjHQSXr (ORCPT + 99 others); Thu, 17 Aug 2023 14:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354443AbjHQSX2 (ORCPT ); Thu, 17 Aug 2023 14:23:28 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C21CD3C05 for ; Thu, 17 Aug 2023 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vJR/YE4jLhlvafKUQzTk10zMBj33RH6GySsj83iQLmk=; b=aMhn3nzymXpTHm8PA1f+ApsZxb KxcM8oJThmbLXgVPEIGWMQUsjs7pTM9vUoxTAbd37ZjIsTCEl9e90MnKXlqtC6Xi428DqUnYYCEy3 TlnOMHgqto7NHhJt35qHDWIj91bkJWFRDEshH/gXKYS/OBLqd+r/KRe9Dw8uIv0lx5R31tCP1qZ/v i5Zub+4BJN/30S3LmcpBGztGz4qxTn0kno+ykjQBRnFXeQjFaasZelp5ekqWqk33PLy7x/8AhFt8c gZrAXxKRtdH2NEBetvOGNnXAjO82dkA2IbnFysXfw5qLluUIQRA82Sa/7xSbOt6TqgFXcqkgRGP0r 2SJYF9Hg==; Received: from [191.193.179.209] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qWhcP-0021I9-Tc; Thu, 17 Aug 2023 20:21:14 +0200 From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?UTF-8?q?=27Marek=20Ol=C5=A1=C3=A1k=27?= , Samuel Pitoiset , Bas Nieuwenhuizen , =?UTF-8?q?Timur=20Krist=C3=B3f?= , Shashank Sharma , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [PATCH v5 5/5] drm/amdgpu: Create version number for coredumps Date: Thu, 17 Aug 2023 15:20:50 -0300 Message-ID: <20230817182050.205925-6-andrealmeid@igalia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230817182050.205925-1-andrealmeid@igalia.com> References: <20230817182050.205925-1-andrealmeid@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even if there's nothing currently parsing amdgpu's coredump files, if we eventually have such tools they will be glad to find a version field to properly read the file. Create a version number to be displayed on top of coredump file, to be incremented when the file format or content get changed. Signed-off-by: André Almeida --- v5: new patch drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c index 579b70a3cdab..e92c81ff27be 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c @@ -192,6 +192,7 @@ static ssize_t amdgpu_devcoredump_read(char *buffer, loff_t offset, p = drm_coredump_printer(&iter); drm_printf(&p, "**** AMDGPU Device Coredump ****\n"); + drm_printf(&p, "version: " AMDGPU_COREDUMP_VERSION "\n"); drm_printf(&p, "kernel: " UTS_RELEASE "\n"); drm_printf(&p, "module: " KBUILD_MODNAME "\n"); drm_printf(&p, "time: %lld.%09ld\n", coredump->reset_time.tv_sec, coredump->reset_time.tv_nsec); diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h index 01e8183ade4b..ec3a409ec509 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h @@ -88,6 +88,9 @@ struct amdgpu_reset_domain { }; #ifdef CONFIG_DEV_COREDUMP + +#define AMDGPU_COREDUMP_VERSION "1" + struct amdgpu_coredump_info { struct amdgpu_device *adev; struct amdgpu_task_info reset_task_info; -- 2.41.0