Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lee Jones <lee@kernel.org>
To:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Stephan Gerhold <stephan@gerhold.net>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Nikita Travkin <nikita@trvn.ru>, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
In-Reply-To: <20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net>
References: <20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net>
Subject: Re: [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up
 supply
Message-Id: <169237365663.1285443.14239471615825184081.b4-ty@kernel.org>
Date:   Fri, 18 Aug 2023 16:47:36 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 15 Aug 2023 19:21:03 +0200, Stephan Gerhold wrote:
> AW2013 has an optional interrupt pin "INTN" which is used to report
> completion of started operations (e.g. power up or LED breath effects).
> The driver does not use it (yet) but it should be already described for
> completeness inside the DT schema.
> 
> Since the interrupt and I2C lines operate in open drain low active mode
> a pull-up supply is needed for correct operation. Unfortunately there
> is no ideal place to describe it in the DT: The pull-up needed for the
> I2C lines could be described on the I2C bus. However, the pull-up
> needed for the interrupt line belongs neither directly to the interrupt
> controller nor to AW2013. Since the AW2013 driver will be typically in
> control of the power management and interrupt masking it makes more
> sense to describe it inside the AW2013 device tree node.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: leds: aw2013: Document interrupt
      commit: 9422bcf125b94e553c795af4f6c59d8e8fd8affa
[2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C
      commit: 2cccb179addedff6a5234e37237fc6b22d9217d4
[3/3] leds: aw2013: Enable pull-up supply for interrupt and I2C
      commit: baca986e1f2c31f8e4b2a6d99d47c3bc844033e8

--
Lee Jones [李琼斯]