Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp106435rdb; Fri, 18 Aug 2023 16:16:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0m2Ud55Rp7y9x45JGkjnUua4wHSgsD2tBN6hcRvLp6fWY85Q2a/fW+f1kQ9suMlhg/hWK X-Received: by 2002:a05:6a20:3ca1:b0:13d:5b70:17da with SMTP id b33-20020a056a203ca100b0013d5b7017damr768598pzj.26.1692400572168; Fri, 18 Aug 2023 16:16:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692400572; cv=none; d=google.com; s=arc-20160816; b=j6TYjapJxzgGHLxGzPU+GBCYPEtmKAuplFU2q4MaSjD2EkzGmYgWtGfNTe9por7uyf Wk/FJTnBUXdWqvDi0FtmiRTx4RVh4fGKu0lQzf9VXYu4qbDPD+QjhgtMjX4veYKgtn9B ENULP3jhiDqsQt8u0T6C2XU3EtHkYtF9qy26JDwAAWn6pOgsBhCDwra5IdeJOQaOldjt inGKmBax2VI6k/3C0AtEA2bPvpM34u3BcSDKfhbaZ4Yregm9lkYdwtuOQfBXWXlf73X+ sMvGIJikKKRjQahSKy3MYnybn4OUt+h52bLvcQtDiu592GSw5H0Ac3CvHRABRrtiIOdp yDDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AvUpvLnpGfL2MdlQ6vgUif65flw6W5VDyXy63Z74Xv4=; fh=k7XzfpyqnKqnwxpqVF0NftrWa2FIpeAcHVbykF5xarA=; b=WLmM5L1PbI0OE6e/ABch1bsxXWS9Y2OWISLqY8fSWzDSEH2J/60q8Ta7HWrIjNC55a KHw/ZleAmX3k8/nLXEKjlvBgrfprCtv7+I+qIDdMoWCMWy8Oz10T98izhikdW8+ysSYV wd+fATkEJEdzqbRmBecnRtL0ZJdMMN/p7M000zYKs3ukQ1OF7Z+bQ3ngjr3mB0vc2wjy trZGx1uB650anJj6SpemMQ66lSQSJTqmVSXW24FgV6K5PnsxcfpZs36peQJg8xMeXkbM poipXL6VALsFrZ8RmBSwoK5LUJbMJV+ZpffmYsDLqVqnPvIH/soODUTMon5OkpRPe5a4 X1Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hkGYpNqR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a170902cacb00b001b8698149fbsi2131942pld.477.2023.08.18.16.15.50; Fri, 18 Aug 2023 16:16:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hkGYpNqR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244287AbjHPK4Q (ORCPT + 99 others); Wed, 16 Aug 2023 06:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244119AbjHPKzr (ORCPT ); Wed, 16 Aug 2023 06:55:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A64261984; Wed, 16 Aug 2023 03:55:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F6EE63FBB; Wed, 16 Aug 2023 10:55:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EC36C433C9; Wed, 16 Aug 2023 10:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692183345; bh=gDvRR64IFGgEzqSspbkO9kJwr/Hf7Tn7Fvxm8rbBCB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hkGYpNqRHxbM+E6Ovm/uyjkJvUEkiJThsfg74hFdwDsp38j05x0Pwnp5qpZfYoOHL pFmv/EiEMngoI2fYL8OQfvhDa/Fds73rI217YwW3FUR4YDB0s37lvLjh65qmiU3v7s Gwux/QKuVdiFlGLUYfNi9QUX7V114HeU5MJs94kDB7bW4iYdci4yH1hNpbeQ7iZl+W oW/KfxCUv5fc5bgHCQZ8wN590xKlUi8oDnSn9o46Zv75Is9xNAVqrYt0BdGIp7xlBD qTQt0dUWOuz72E9iQ9aIMu/IQReg7cQGI8eY/DmbLH61qSXXnRbbhdnyDXpRj3Sz9n 8AXXO0q8g6Iaw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 08/10] tty: tty_buffer: better types in __tty_buffer_request_room() Date: Wed, 16 Aug 2023 12:55:28 +0200 Message-ID: <20230816105530.3335-9-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816105530.3335-1-jirislaby@kernel.org> References: <20230816105530.3335-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * use bool for 'change' as it holds a result of a boolean. * use size_t for 'left', so it is the same as 'size' which it is compared to. Both are supposed to contain an unsigned value. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/tty_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index e162318d6c31..414bb7f9155f 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c @@ -263,7 +263,8 @@ static int __tty_buffer_request_room(struct tty_port *port, size_t size, { struct tty_bufhead *buf = &port->buf; struct tty_buffer *b, *n; - int left, change; + size_t left; + bool change; b = buf->tail; if (!b->flags) -- 2.41.0