Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20230814112615.42448-1-andriy.shevchenko@linux.intel.com> <CAMRc=MfhoeMfC7gAcKioKpkCA1jykyqGSH4vg7Hpu9bb=yeGaA@mail.gmail.com>
In-Reply-To: <CAMRc=MfhoeMfC7gAcKioKpkCA1jykyqGSH4vg7Hpu9bb=yeGaA@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 14 Aug 2023 19:28:36 +0300
Message-ID: <CAHp75VdLuj1UZB+UqfvkrBUreT6NdFY5xrXASncinj-_XVqEbA@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] gpiolib: sysfs: Do unexport GPIO when user asks
 for it
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>,
        =?UTF-8?B?TWFyZWsgQmVow7pu?= <kabel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 14, 2023 at 7:13=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.pl>=
 wrote:
> On Mon, Aug 14, 2023 at 1:19=E2=80=AFPM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > It seems that sysfs interface implicitly relied on the gpiod_free()
> > to unexport the line. This is not good and prone to regressions.
> > Fix it by explicitly calling gpiod_unexport().
> >
>
> I wouldn't say it's prone to regressions, it's literally just that
> gpiod_free() should not deal with sysfs.
>
> How about that for commit message (I can change it when applying):
>
> It seems that sysfs interface implicitly relied on the gpiod_free()
> to unexport the line. This is logically incorrect as core gpiolib should
> not deal with sysfs so instead of restoring it, let's call gpiod_unexport=
()
> from sysfs code.

I'm fine with it, go ahead and apply with the change. Thank you!

--=20
With Best Regards,
Andy Shevchenko