Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 18 Aug 2023 18:39:02 +0100
From:   Lee Jones <lee@kernel.org>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Justin Stitt <justinstitt@google.com>, Pavel Machek <pavel@ucw.cz>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] leds: pca955x: fix -Wvoid-pointer-to-enum-cast warning
Message-ID: <20230818173902.GE986605@google.com>
References: <20230816-void-drivers-leds-leds-pca955x-v1-1-2967e4c1bdcc@google.com>
 <20230818160154.GZ986605@google.com>
 <20230818160648.GA939927@dev-arch.thelio-3990X>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230818160648.GA939927@dev-arch.thelio-3990X>
Precedence: bulk

On Fri, 18 Aug 2023, Nathan Chancellor wrote:

> On Fri, Aug 18, 2023 at 05:01:54PM +0100, Lee Jones wrote:
> > On Wed, 16 Aug 2023, Justin Stitt wrote:
> > 
> > > When building with clang 18 I see the following warning:
> > > |      drivers/leds/leds-pca955x.c:487:15: warning: cast to smaller integer
> > > |      type 'enum pca955x_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]
> > > |        487 |                 chip_type = (enum pca955x_type)md;
> > > 
> > > This is due to the fact that `md` is a void* while `enum pca995x_type` has the
> > > size of an int.
> > > 
> > > Add uintptr_t cast to silence clang warning while also keeping enum cast
> > > for readability and consistency with other `chip_type` assignment just a
> > > few lines below:
> > > |	chip_type = (enum pca955x_type)id->driver_data;
> > > 
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1910
> > > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > 
> > A review from Nathan would be good here.
> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Thank you.

-- 
Lee Jones [李琼斯]