Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 15 Aug 2023 17:59:34 +0200
From:   Michael Walle <michael@walle.cc>
To:     Hsin-Yi Wang <hsinyi@chromium.org>,
        Tudor Ambarus <tudor.ambarus@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Bjorn Andersson <andersson@kernel.org>
CC:     Pratyush Yadav <pratyush@kernel.org>,
        "Miquel Raynal )" <miquel.raynal@bootlin.com>,
        "Richard Weinberger )" <richard@nod.at>,
        "Vignesh Raghavendra )" <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        cros-qcom-dts-watchers@chromium.org,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH 0/4] Add a property to override the quad mode
User-Agent: K-9 Mail for Android
In-Reply-To: <20230815154412.713846-1-hsinyi@chromium.org>
References: <20230815154412.713846-1-hsinyi@chromium.org>
Message-ID: <202A0C36-D1F6-4BB4-BDEC-F36A76B757A2@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,=20

>On gigadevice gd25lq64c, the quad mode is enabled after BFPT is parsed=2E
>According to datasheet[1], Quad enable (QE) bit needs to be set to 0 to
>use write protection (WP) pin=2E It also recommends setting default value=
 of
>QE to 0 to avoid a potential short issue=2E

So you are using either dual or single io mode=2E Why can't you use the de=
vice tree property spi-{tx,rx}-bus-width?=20

>Add a disable-quad-mode property in devicetree that platform can use it t=
o
>override the quad mode status parsed from BFPT to use write protection=2E
>
>[1]
>https://www=2Eelm-tech=2Ecom/ja/products/spi-flash-memory/gd25lq64/gd25lq=
64=2Epdf

should be a link on the vendor Homepage if possible=2E=20

-michael