Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp339255rdb; Sat, 19 Aug 2023 04:07:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRmBEp9wY9hOKC3AY2IbsXhL9YwBw2j9QIKPXvUc3zILyO+abKGPkTR9SJ4BVY+6PzHqAW X-Received: by 2002:a05:6a20:938d:b0:13c:bda3:79c3 with SMTP id x13-20020a056a20938d00b0013cbda379c3mr2552580pzh.4.1692443245225; Sat, 19 Aug 2023 04:07:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692443245; cv=none; d=google.com; s=arc-20160816; b=k6CZogowanOlnsusLmT+fJa7tzDFu4rhS2QYbi+6sY8N4JFZ+6ISnaG0uWAvhAXcYU bIi8rCgwliV79DMU2xQ+8w++EB8Wb4r/afScVx4JXyVqShXOPgJNK7880RoVIT48yrOy l6sadbkQ5SI/7/mgNH5TatPYSLJQnoTdyFM7XzmxdZcbn98ub/o7j2GJ5OPjy9v0tz/9 k3Yaju4Ez9GEFxFmGWML1J0bPMgSwG6CcBozVKUCglTyflfpGzGp3uOx9Yeh6EVn0HJ1 3lTwMIpRWrH5lyDo9nA3/RFHZMpU67QgOEt/qb3r1osQU9DFLFjwscbSpIwwFPoIb1qW fcLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=uPhe0JA8b1Tomz4XPwFNw7O5eVIZGQI+BEUUfcdHWYE=; fh=TcKT1bXnSqTFTXmJmUyvK/pKF2vmlJmBre0KLXL+nzo=; b=xId2rnsP4MiIvFot4IuWJ4S0tz0zOqn2KQ/aSIfz7M3sAJC6i5KIIqOfH1hEUiYQiE okM8+IqS1D25ObiWL6o/u28WiN1y3lx38jZTMwZZ5yPEmCe9G3epjn8pum0hOBEn6H2D C2ZCXuKG6Epn62g+nvTlwHx0jMDXGlUfBEteEfOV67nIPaXCNFj4ewJF+LAbySMn6VsS OGJ2HHw7vohJg6H8LcKEU328k8oLf5csTEostzBgAo2qnO4+dP2clRA1N4Tc3hntmeTv msdbzYEQ+MyvFeIG2hSwVNXCvzRBpuQ/TOnGyrr1w8d4C9OHj9YGkpMQp/drqrf20xEn NqgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id k186-20020a6384c3000000b00565e756639asi3292335pgd.389.2023.08.19.04.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 04:07:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 40F085AFCD; Sat, 19 Aug 2023 01:33:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376622AbjHRLXA (ORCPT + 99 others); Fri, 18 Aug 2023 07:23:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376641AbjHRLWf (ORCPT ); Fri, 18 Aug 2023 07:22:35 -0400 Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBC4449F; Fri, 18 Aug 2023 04:22:13 -0700 (PDT) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 90689427C1; Fri, 18 Aug 2023 13:22:11 +0200 (CEST) Message-ID: <49c2e556-fd75-751e-3b0c-c51c3245f94c@proxmox.com> Date: Fri, 18 Aug 2023 13:22:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: "Use slab_build_skb() instead" deprecation warning triggered by tg3 Content-Language: en-US To: Bagas Sanjaya , linux-kernel@vger.kernel.org Cc: siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, jdelvare@suse.com, Guenter Roeck , netdev@vger.kernel.org, linux-hwmon@vger.kernel.org, keescook@chromium.org, Linux Regressions References: <1bd4cb9c-4eb8-3bdb-3e05-8689817242d1@proxmox.com> From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18.08.23 um 13:12 schrieb Bagas Sanjaya: > On Fri, Aug 18, 2023 at 10:05:11AM +0200, Fiona Ebner wrote: >> Hi, >> we've got a user report about the WARN_ONCE introduced by ce098da1497c >> ("skbuff: Introduce slab_build_skb()") [0]. The stack trace indicates >> that the call comes from the tg3 module. While this is still kernel 6.2 >> and I can't verify that the issue is still there with newer kernels, I >> don't see related changes in drivers/net/ethernet/broadcom/tg3.* after >> ce098da1497c, so I thought I should let you know. >> > > Thanks for the regression report. I'm adding it to regzbot: > > #regzbot ^introduced: ce098da1497c6d > #regzbot link: https://forum.proxmox.com/threads/132338/ > > PS: The proxmox forum link (except full dmesg log pasted there) is in > German, so someone fluent in the language can be helpful here. > At the moment, there is not much other text: The user says that they got the trace after a recent upgrade, but cannot notice any real problems and I'm telling them that it's a deprecation warning and that I reported it upstream. If I should ask for some specific information, please let me know :) But not sure if more information from the user is even required here or if the fix will just be similar to the one in 8c495270845d ("bnx2x: use the right build_skb() helper"). Best Regards, Fiona