Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 16 Aug 2023 02:23:00 +0000
To:     Nils Tonnaett <ntonnatt@ccrma.Stanford.EDU>
From:   Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards
Message-ID: <87h6ozafpb.fsf@protonmail.com>
In-Reply-To: <20230815201959.17569-1-ntonnatt@ccrma.stanford.edu>
References: <20230811202932.30413-1-ntonnatt@ccrma.stanford.edu> <20230815201959.17569-1-ntonnatt@ccrma.stanford.edu>
Feedback-ID: 26003777:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Tue, 15 Aug, 2023 13:19:59 -0700 "Nils Tonnaett" <ntonnatt@ccrma.Stanfor=
d.EDU> wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
> V1 -> V2:
> =09- Start commit message subject with HID: apple: instead of hid:
> =09- Comma terminate last member of array
>
>  drivers/hid/hid-apple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_appl=
e_keyboards[] =3D {
>  =09{ "SONiX USB DEVICE" },
>  =09{ "Keychron" },
>  =09{ "AONE" },
> -=09{ "GANSS" }
> +=09{ "GANSS" },
> +=09{ "Hailuck" },
>  };
>
>  static bool apple_is_non_apple_keyboard(struct hid_device *hdev)

Reviewed-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>